From: "Michael Chan" <mchan@broadcom.com>
To: hadi@cyberus.ca
Cc: "Matt Carlson" <mcarlson@broadcom.com>,
"netdev" <netdev@vger.kernel.org>
Subject: Re: [PATCH][TG3]Some cleanups
Date: Tue, 02 Oct 2007 16:33:53 -0700 [thread overview]
Message-ID: <1191368033.5961.22.camel@dell> (raw)
In-Reply-To: <1191328627.4353.15.camel@localhost>
On Tue, 2007-10-02 at 08:37 -0400, jamal wrote:
> The simplest solution seems to me to modify the definition of
> TG3_SKB_CB
> as i did for e1000 from:
> (struct tg3_tx_cbdata *)&((__skb)->cb[0])
> to:
> (struct tg3_tx_cbdata *)&((__skb)->cb[8])
>
> that way the vlan tags are always present and no need to recreate
> them.
> What do you think?
Seems ok to me. I think we should make it more clear that we're
skipping over the VLAN tag:
(struct tg3_tx_cbdata *)&((__skb)->cb[sizeof(struct vlan_skb_tx_cookie)])
next prev parent reply other threads:[~2007-10-02 22:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 18:11 [PATCH][TG3]Some cleanups jamal
2007-09-30 18:12 ` jamal
2007-10-02 0:21 ` Michael Chan
2007-10-02 12:37 ` jamal
2007-10-02 23:33 ` Michael Chan [this message]
2007-10-03 13:18 ` jamal
2007-10-07 15:12 ` jamal
2007-10-08 6:32 ` David Miller
2007-10-08 13:42 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191368033.5961.22.camel@dell \
--to=mchan@broadcom.com \
--cc=hadi@cyberus.ca \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox