From: Ian Kumlien <pomac@vapor.com>
To: Bill Davidsen <davidsen@tmr.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>,
Linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: jumbo frame regression fix
Date: Wed, 03 Oct 2007 20:28:21 +0200 [thread overview]
Message-ID: <1191436101.26233.32.camel@localhost> (raw)
In-Reply-To: <4703D9B6.109@tmr.com>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
On ons, 2007-10-03 at 14:04 -0400, Bill Davidsen wrote:
> Ian Kumlien wrote:
> > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote:
> >> Remove unneeded check that caused problems with jumbo frame sizes.
> >> The check was recently added and is wrong.
> >> When using jumbo frames the sky2 driver does fragmentation, so
> >> rx_data_size is less than mtu.
> >
> > Confirmed working.
> >
> > Now running with 9k mtu with no errors, =)
>
> Have you verified that you are actually getting jumbo packets out of the
> NIC? I had one machine which did standard packets silently using sky2
> and jumbo using sk98lin. I was looking for something else with tcpdump
> and got one of those WTF moments when I saw all the tiny packets.
20:27:06.542461 IP pi.local > blue.local: ICMP echo request, id 27173, seq 42, length 8008
20:27:06.543136 IP blue.local > pi.local: ICMP echo reply, id 27173, seq 42, length 8008
That should solve it for us, right? =)
--
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2007-10-03 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1191372129.26233.12.camel@localhost>
2007-10-03 1:02 ` [PATCH] sky2: jumbo frame regression fix Stephen Hemminger
2007-10-03 1:07 ` Jeff Garzik
2007-10-03 4:53 ` Stephen Hemminger
2007-10-03 4:58 ` Jeff Garzik
2007-10-03 1:34 ` Ian Kumlien
2007-10-03 4:59 ` Stephen Hemminger
2007-10-03 7:37 ` Ian Kumlien
2007-10-03 8:29 ` iank
2007-11-24 16:23 ` [SKY2] Problems (2.6.24-rc3-git1) Ian Kumlien
2007-10-03 18:04 ` [PATCH] sky2: jumbo frame regression fix Bill Davidsen
2007-10-03 18:28 ` Ian Kumlien [this message]
2007-10-03 17:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191436101.26233.32.camel@localhost \
--to=pomac@vapor.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=davidsen@tmr.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).