From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, mcarlson@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH][TG3]Some cleanups
Date: Mon, 08 Oct 2007 09:42:03 -0400 [thread overview]
Message-ID: <1191850923.4352.50.camel@localhost> (raw)
In-Reply-To: <20071007.233235.115620499.davem@davemloft.net>
On Sun, 2007-07-10 at 23:32 -0700, David Miller wrote:
> This "cleanup" only makes sense if we go with your TX batching
> interfaces.
>
> They make the TX batching support patch for this driver "nice" and
> "clean", but it makes zero sense in any other context.
> In fact, it
> adds more memory references in the TX pacth, and in fact does so by
> adding usage of the skb->cb[] which the driver didn't need to do
> previously.
>
> So I'm going to hold off on this one for now, keep it in your TX
> batching changes instead.
The batching benefits from it because it reuses code. But i would put
readability as something of no value.
In any case i would defer this for later.
cheers,
jamal
prev parent reply other threads:[~2007-10-08 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 18:11 [PATCH][TG3]Some cleanups jamal
2007-09-30 18:12 ` jamal
2007-10-02 0:21 ` Michael Chan
2007-10-02 12:37 ` jamal
2007-10-02 23:33 ` Michael Chan
2007-10-03 13:18 ` jamal
2007-10-07 15:12 ` jamal
2007-10-08 6:32 ` David Miller
2007-10-08 13:42 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191850923.4352.50.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).