From: jamal <hadi@cyberus.ca>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][E1000E] some cleanups
Date: Tue, 09 Oct 2007 09:29:41 -0400 [thread overview]
Message-ID: <1191936581.4373.192.camel@localhost> (raw)
In-Reply-To: <470AB1EC.2080000@intel.com>
On Mon, 2007-08-10 at 15:40 -0700, Kok, Auke wrote:
>
> My biggest problem with the patch as you sent it that it's a tonload of changes
> and no implicit benefit immediately as I can see.
The patch looks scary but is pretty tame when you apply it and stare at
it.
> I would really have to see the
> LLTX change as well to make a wellfounded decision whether it is the right thing
> to go and overhaul this part of the driver or not :)
>
> I'm not particularly against the changes per se though.
>
> so please, if needed offlist send me those LLTX changes as well.
Dont worry about it - i didnt get any love for a similar patch i did for
tg3 either ;-> I will hold onto it for now. I could do the un-LLTX
outside of this - would you like that for both e1000/e1000e ?
cheers,
jamal
next prev parent reply other threads:[~2007-10-09 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 17:41 [PATCH][E1000E] some cleanups jamal
2007-09-30 18:16 ` Kok, Auke
2007-09-30 19:01 ` jamal
2007-09-30 19:23 ` Jeff Garzik
2007-09-30 19:31 ` jamal
2007-10-01 1:59 ` Kok, Auke
2007-10-02 12:25 ` jamal
2007-10-02 17:06 ` Kok, Auke
2007-10-02 17:43 ` Kok, Auke
2007-10-03 13:18 ` jamal
2007-10-07 16:15 ` jamal
2007-10-08 22:40 ` Kok, Auke
2007-10-09 13:29 ` jamal [this message]
2007-10-09 16:02 ` Kok, Auke
2007-10-09 22:18 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191936581.4373.192.camel@localhost \
--to=hadi@cyberus.ca \
--cc=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).