From: "Eliezer Tamir" <eliezert@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jeff@garzik.org, mchan@broadcom.com
Subject: Re: [PATCH][BNX2X] round three
Date: Thu, 11 Oct 2007 19:53:39 +0200 [thread overview]
Message-ID: <1192125219.29746.143.camel@eliezer> (raw)
In-Reply-To: <20071010.175942.55509516.davem@davemloft.net>
On Wed, 2007-10-10 at 17:59 -0700, David Miller wrote:
...
> I was going to add this to the tree for 2.6.24 but there is simply
> too much super-ugly stuff in this driver for me to do so.
We will rewrite bnx2x_hsi.h bnx2x_init.h and bnx2x_init_vlaues.h.
Does bnx2x_asm.h look OK?
> Look, there is zero way I'm adding a driver that's written like this
> to the tree.
>
...
> This huge header file full of register programming magic goes way
> beyond the limits of "reasonable" and has to go.
Will it be OK if we replace it with 4-5 headers so we can maintain them
better manually. (I'm asking what is the upper bound to the number of
header files you would consider reasonable for this driver.)
Thanks
Eliezer
next prev parent reply other threads:[~2007-10-11 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 17:49 [PATCH][BNX2X] round three Eliezer Tamir
2007-10-10 19:52 ` Eliezer Tamir
2007-10-11 0:59 ` David Miller
2007-10-11 17:53 ` Eliezer Tamir [this message]
2007-10-11 21:40 ` David Miller
2007-10-11 1:28 ` Stephen Hemminger
2007-10-11 17:13 ` Eliezer Tamir
2007-10-11 1:54 ` [PATCH][BNX2X] round three - sparse warnings Stephen Hemminger
2007-10-11 17:21 ` Eliezer Tamir
2007-10-12 14:47 ` [PATCH][BNX2X] round three Andi Kleen
2007-10-12 22:03 ` David Miller
2007-10-15 15:27 ` Eliezer Tamir
2007-10-15 16:05 ` Andi Kleen
2007-10-15 16:22 ` Eliezer Tamir
2007-10-15 16:24 ` Andi Kleen
2007-10-15 19:42 ` David Miller
2007-10-15 19:38 ` David Miller
2007-10-15 21:58 ` Stephen Hemminger
2007-10-15 22:00 ` David Miller
2007-10-15 22:06 ` Stephen Hemminger
2007-10-16 15:00 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192125219.29746.143.camel@eliezer \
--to=eliezert@broadcom.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).