netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Henriksson <andreas@fatal.se>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
	Andreas Henriksson <andreas@fatal.se>
Subject: [PATCH 05/12] Fix typo in tunnel code (o_key vs. i_key).
Date: Fri, 12 Oct 2007 10:56:40 +0200	[thread overview]
Message-ID: <1192179407-22461-5-git-send-email-andreas@fatal.se> (raw)
In-Reply-To: <1192179407-22461-4-git-send-email-andreas@fatal.se>

From: Herbert Xu <herbert@gondor.apana.org.au>

If a dotted quad ikey is specified for GRE tunnels, it gets set as the
okey instead.  This patch fixes it. (http://bugs.debian.org/200714)

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 ip/iptunnel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ip/iptunnel.c b/ip/iptunnel.c
index 828d80a..aee526b 100644
--- a/ip/iptunnel.c
+++ b/ip/iptunnel.c
@@ -113,7 +113,7 @@ static int parse_args(int argc, char **argv, int cmd, struct ip_tunnel_parm *p)
 			NEXT_ARG();
 			p->i_flags |= GRE_KEY;
 			if (strchr(*argv, '.'))
-				p->o_key = get_addr32(*argv);
+				p->i_key = get_addr32(*argv);
 			else {
 				if (get_unsigned(&uval, *argv, 0)<0) {
 					fprintf(stderr, "invalid value of \"ikey\"\n");
-- 
1.5.3.4


  reply	other threads:[~2007-10-12  8:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  8:56 [PATCH 01/12] Fix various typos and nitpicks Andreas Henriksson
2007-10-12  8:56 ` [PATCH 02/12] Add parameters to usage help text Andreas Henriksson
2007-10-12  8:56   ` [PATCH 03/12] Prevent renaming interfaces to empty string Andreas Henriksson
2007-10-12  8:56     ` [PATCH 04/12] Fix up various problems in netbug script Andreas Henriksson
2007-10-12  8:56       ` Andreas Henriksson [this message]
2007-10-12  8:56         ` [PATCH 06/12] Remove bogus reference to tc-filters(8) from tc(8) manpage Andreas Henriksson
2007-10-12  8:56           ` [PATCH 07/12] Fix corruption when using batch files with comments and broken lines Andreas Henriksson
2007-10-12  8:56             ` [PATCH 08/12] Fix ematch cmp and nbyte syntax help text Andreas Henriksson
2007-10-12  8:56               ` [PATCH 09/12] Add new rtacct/nstat manpages and additional symlinks Andreas Henriksson
2007-10-12  8:56                 ` [PATCH 10/12] Fix off-by-one in print of wrandom algo Andreas Henriksson
2007-10-12  8:56                   ` [PATCH 11/12] Fix overflow in time2tick / tick2time Andreas Henriksson
2007-10-12  8:56                     ` [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage Andreas Henriksson
2007-10-12 21:50                       ` Stephen Hemminger
2007-10-12 22:49                         ` Patrick McHardy
2007-10-17 16:50                         ` Andreas Henriksson
2007-10-17 17:05                           ` Stephen Hemminger
2007-10-17 17:58                             ` Andreas Henriksson
2007-10-17 18:02                               ` Stephen Hemminger
2007-10-18  8:13                                 ` Andreas Henriksson
2007-10-12 21:39                   ` [PATCH 10/12] Fix off-by-one in print of wrandom algo Stephen Hemminger
2007-10-12 17:14       ` [PATCH 04/12] Fix up various problems in netbug script Stephen Hemminger
2007-10-12 17:39         ` Andreas Henriksson
2007-10-12 12:01     ` [PATCH 03/12] Prevent renaming interfaces to empty string Patrick McHardy
2007-10-12 17:07     ` Stephen Hemminger
2007-10-12 17:45       ` Andreas Henriksson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192179407-22461-5-git-send-email-andreas@fatal.se \
    --to=andreas@fatal.se \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).