From: Andreas Henriksson <andreas@fatal.se>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, Alexander Wirt <formorer@debian.org>
Subject: Re: [PATCH 03/12] Prevent renaming interfaces to empty string.
Date: Fri, 12 Oct 2007 19:45:54 +0200 [thread overview]
Message-ID: <1192211154.4733.67.camel@localhost.localdomain> (raw)
In-Reply-To: <20071012100743.0c1a11f8@freepuppy.rosehill>
On fre, 2007-10-12 at 10:07 -0700, Stephen Hemminger wrote:
> > if (newname && strcmp(dev, newname)) {
> > + if (strlen(newname) == 0) {
> > + printf("\"\" is not valid device identifier\n");
> > + return -1;
> > + }
> > if (do_changename(dev, newname) < 0)
> > return -1;
> > dev = newname;
>
> The kernel should already be preventing this?
Looks like something prevents the interface to end up with no name, but
there's no error message...
./ip/ip is the "vanilla" and /sbin/ip is debians version.
$ sudo ./ip/ip link set skif name ""
$ echo $?
0
$ sudo /sbin/ip link set skif name ""
"" is not valid device identifier
$ echo $?
255
Reporting the error is probably the preferred behaviour (and return code
set to error is most likely helpful for scripts).
--
Regards,
Andreas Henriksson
prev parent reply other threads:[~2007-10-12 17:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 8:56 [PATCH 01/12] Fix various typos and nitpicks Andreas Henriksson
2007-10-12 8:56 ` [PATCH 02/12] Add parameters to usage help text Andreas Henriksson
2007-10-12 8:56 ` [PATCH 03/12] Prevent renaming interfaces to empty string Andreas Henriksson
2007-10-12 8:56 ` [PATCH 04/12] Fix up various problems in netbug script Andreas Henriksson
2007-10-12 8:56 ` [PATCH 05/12] Fix typo in tunnel code (o_key vs. i_key) Andreas Henriksson
2007-10-12 8:56 ` [PATCH 06/12] Remove bogus reference to tc-filters(8) from tc(8) manpage Andreas Henriksson
2007-10-12 8:56 ` [PATCH 07/12] Fix corruption when using batch files with comments and broken lines Andreas Henriksson
2007-10-12 8:56 ` [PATCH 08/12] Fix ematch cmp and nbyte syntax help text Andreas Henriksson
2007-10-12 8:56 ` [PATCH 09/12] Add new rtacct/nstat manpages and additional symlinks Andreas Henriksson
2007-10-12 8:56 ` [PATCH 10/12] Fix off-by-one in print of wrandom algo Andreas Henriksson
2007-10-12 8:56 ` [PATCH 11/12] Fix overflow in time2tick / tick2time Andreas Henriksson
2007-10-12 8:56 ` [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage Andreas Henriksson
2007-10-12 21:50 ` Stephen Hemminger
2007-10-12 22:49 ` Patrick McHardy
2007-10-17 16:50 ` Andreas Henriksson
2007-10-17 17:05 ` Stephen Hemminger
2007-10-17 17:58 ` Andreas Henriksson
2007-10-17 18:02 ` Stephen Hemminger
2007-10-18 8:13 ` Andreas Henriksson
2007-10-12 21:39 ` [PATCH 10/12] Fix off-by-one in print of wrandom algo Stephen Hemminger
2007-10-12 17:14 ` [PATCH 04/12] Fix up various problems in netbug script Stephen Hemminger
2007-10-12 17:39 ` Andreas Henriksson
2007-10-12 12:01 ` [PATCH 03/12] Prevent renaming interfaces to empty string Patrick McHardy
2007-10-12 17:07 ` Stephen Hemminger
2007-10-12 17:45 ` Andreas Henriksson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192211154.4733.67.camel@localhost.localdomain \
--to=andreas@fatal.se \
--cc=formorer@debian.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).