netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: panther@balabit.hu
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: Resend: [IPROUTE2 PATCH] Interface group as new ip link option
Date: Tue, 16 Oct 2007 07:26:42 -0400	[thread overview]
Message-ID: <1192534002.4480.52.camel@localhost> (raw)
In-Reply-To: <47149B04.30607@balabit.hu>

On Tue, 2007-16-10 at 13:05 +0200, Laszlo Attila Toth wrote:

> That sounds great but for what whould you like to use? It may help me 
> for the implementation.

For example i may want to add a tc rule to a group of interfaces.
tc BNF roughly looks like:
tc <object> <operation> <target>

Where targe is := <dev devname>
It may be useful to extend "target" to include alternatively a group of
devices.
The way i would see that done is to add a little wrapper to tc to first
ask the kernel for a list of interfaces and then invoke each with the
equivalent of current syntax.
Did that make sense?

> Currently it is not available since the the 
> net_device structure holds the group id and for this get operation an 
> iteration (of net_devices) may be necessary...

I understand - but i would rather do the iteration in the kernel than in
user space and save myself a gazillion netlink messages.

> We didn't want to use multiple groups in favour of masked group ids. 
> What kind of usage needs other implementation?

Same lazyperson use cases as above; in one case i may want to set a rule
to group = {eth0, eth1, eth10} and in another {eth0,eth5}. I realize
this may be more involved something clever for an implementation (eg
using a bitmap instead of a straight int) - so if it not a simple thing,
just defer it to some later time.

Ok, now that you are asking, heres another one feature request for
you;-> It would be nice if i can set a group based on a regular
expression of a devices name; eg "ppp*". Use case for this, off top of
my head (without looking at your syntax):

ip set group 10 ppp*

And equivalent to "ifconfig ppp*" so i dont list 10K interfaces
ip list group 10 or pass any 5K messages to user space

cheers,
jamal


  reply	other threads:[~2007-10-16 11:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ifgroup.20071015.1192520046.panther@balabit.hu>
2007-10-16  8:01 ` [PATCH 0/2] Interface groups Laszlo Attila Toth
2007-10-16  8:01 ` Laszlo Attila Toth
2007-10-16  8:50   ` Philip Craig
2007-10-16  9:47     ` Laszlo Attila Toth
     [not found] ` <1824b3d462b1d85aaf33941cf082c4e018d5bff7.1192460167.git.panther@balabit.hu>
2007-10-16  8:01   ` [PATCH 1/2] Interface group: core (netlink) part Laszlo Attila Toth
2007-10-16  8:01   ` Laszlo Attila Toth
2007-10-16  8:34     ` Patrick McHardy
     [not found]   ` <661f8f2fdb86cc70bdefd12403ecb0eaa7cfadd6.1192460168.git.panther@balabit.hu>
2007-10-16  8:01     ` [PATCH 2/2] Interface group match - netfilter part Laszlo Attila Toth
2007-10-16  8:01     ` Laszlo Attila Toth
2007-10-16  8:30       ` Patrick McHardy
2007-10-16  9:46         ` Laszlo Attila Toth
2007-10-16 14:46         ` Jan Engelhardt
2007-10-17  9:08         ` Laszlo Attila Toth
2007-10-17  9:11           ` Patrick McHardy
     [not found] ` <a6713ba13c49b7fa20073d8abf1862480c2799e0.1192457385.git.panther@balabit.hu>
2007-10-16  8:01   ` [IPROUTE2 PATCH] Interface group as new ip link option Laszlo Attila Toth
2007-10-16  8:01   ` Laszlo Attila Toth
2007-10-16  8:38     ` Patrick McHardy
2007-10-16  9:33       ` Laszlo Attila Toth
2007-10-16  9:03   ` Resend: " Laszlo Attila Toth
2007-10-16  9:03   ` Laszlo Attila Toth
2007-10-16  9:11     ` Patrick McHardy
2007-10-16 10:45   ` jamal
2007-10-16 11:05     ` Laszlo Attila Toth
2007-10-16 11:26       ` jamal [this message]
2007-10-16 11:47         ` Laszlo Attila Toth
2007-10-16 12:08           ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192534002.4480.52.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=panther@balabit.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).