From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: netif_napi_add vs. multiple netdev's
Date: Wed, 17 Oct 2007 08:24:23 +1000 [thread overview]
Message-ID: <1192573463.11899.20.camel@pasglop> (raw)
In-Reply-To: <20071016.151616.70218795.davem@davemloft.net>
On Tue, 2007-10-16 at 15:16 -0700, David Miller wrote:
> And it's unfortunately buggy.
>
> For example, the sky2_suspend() code iterates over the ports
> and calls sky2_down() on each one that is up.
>
> That will call napi_disable() on the same NAPI instance if
> multiple ports are up, and thus hang the machine.
>
> This is why, Stephen, for the second time, I'm telling you
> that perhaps you should put the NAPI instance into the
> sky2_port struct.
Can sky2 send/mask interrupts separately per port ? The reason why I
can't do that with EMAC is why I'm doing multiple ports per NAPI
instance...
If sky2 sticks to doing like EMAC, then it probably also needs to do
like EMAC which is to have it's own port_disable/enable that use local
per-port disable bits. (It may do a real napi_disable when all ports are
disabled, I suppose, though I don't currently do it in EMAC).
Ben.
next prev parent reply other threads:[~2007-10-16 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:47 netif_napi_add vs. multiple netdev's Benjamin Herrenschmidt
2007-10-16 16:10 ` Stephen Hemminger
2007-10-16 22:16 ` David Miller
2007-10-16 22:24 ` Benjamin Herrenschmidt [this message]
2007-10-16 23:37 ` Stephen Hemminger
2007-10-16 23:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192573463.11899.20.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).