From: "Eliezer Tamir" <eliezert@broadcom.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"Michael Chan" <mchan@broadcom.com>,
"jeff@garzik.org" <jeff@garzik.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "Max Asbock" <masbock@us.ibm.com>
Subject: [RFC][BNX2X] .h files rewrite
Date: Sun, 28 Oct 2007 22:17:50 +0200 [thread overview]
Message-ID: <1193602670.4836.25.camel@eliezer> (raw)
Dave,
Please take a look and tell me if this is better than the last attempt.
Main changes:
* Rewrite of the init code:
1. Full rewrite of the generated code into something easier to read.
2. Removed zeroes by adding a zero command.
3. Big chucks of data are read by the chip using the DMA engine (instead of being written by the driver).
4. Gzipped more of the data.
* Removed BE microcode, the swapping is done in the driver instead.
* Rewrite of the HSI - broke it into three files bnx2x_hsi.h bnx2x_reg.h and bnx2x_fw_defs.h
* Fixed SPARSE warnings.
* Fixed all but three checkpatch.pl warnings. (IMHO they are false positives)
The diff is against latest net-2.6.
ftp link:
ftp://Net_sys_anon@ftp1.broadcom.com/0001-bnx2x-h-file-rewrite.txt
gzipped:
ftp://Net_sys_anon@ftp1.broadcom.com/0001-bnx2x-h-file-rewrite.txt.gz
(will also attache patch inline as reply to this email for review)
Thanks
Eliezer
next reply other threads:[~2007-10-28 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 20:17 Eliezer Tamir [this message]
[not found] ` <1193602875.4836.28.camel@eliezer>
2007-10-29 8:39 ` [RFC][BNX2X] .h files rewrite David Miller
2007-10-31 10:14 ` Eliezer Tamir
2007-10-31 10:53 ` David Miller
2007-11-02 23:35 ` Max Asbock
2007-11-04 7:47 ` Eliezer Tamir
2007-11-12 23:13 ` Ram Pai
2007-11-12 23:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193602670.4836.25.camel@eliezer \
--to=eliezert@broadcom.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=masbock@us.ibm.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).