From: Romano Giannetti <romanol@upcomillas.es>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Francois Romieu <romieu@fr.zoreil.com>,
Jeff Garzik <jeff@garzik.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Edward Hsu <edward_hsu@realtek.com.tw>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] r8169: don't call napi_disable if not doing NAPI
Date: Mon, 29 Oct 2007 09:56:42 +0100 [thread overview]
Message-ID: <1193648202.15743.1.camel@localhost> (raw)
In-Reply-To: <20071026113305.57dea765@freepuppy.rosehill>
On Fri, 2007-10-26 at 11:33 -0700, Stephen Hemminger wrote:
> Don't call napi_disable if not configured.
> And make sure that any misuse of napi_xxx in future fails
> with a compile error.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
This fix the problem for me (at least, after 8 suspend/resume cycles).
Thanks.
Tested-by: Romano Giannetti <romano.giannetti@gmail.com>
--
Sorry for the disclaimer --- ¡I cannot stop it!
--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.
This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation.
prev parent reply other threads:[~2007-10-29 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0710232057080.30120@woody.linux-foundation.org>
[not found] ` <1193232344.32208.0.camel@localhost>
[not found] ` <20071024142759.GA13657@elte.hu>
[not found] ` <1193241191.14314.8.camel@localhost>
[not found] ` <20071024155521.GA16690@elte.hu>
[not found] ` <1193242267.6914.6.camel@twins>
[not found] ` <1193378269.17910.4.camel@localhost>
2007-10-26 6:37 ` 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioctl() / dev_close() / rtl8169_down() Ingo Molnar
2007-10-26 16:48 ` Stephen Hemminger
2007-10-26 17:56 ` Ingo Molnar
2007-10-26 18:33 ` [PATCH] r8169: don't call napi_disable if not doing NAPI Stephen Hemminger
2007-10-26 20:17 ` Francois Romieu
2007-10-28 22:18 ` Romano Giannetti
2007-10-29 8:56 ` Romano Giannetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193648202.15743.1.camel@localhost \
--to=romanol@upcomillas.es \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edward_hsu@realtek.com.tw \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).