From: Sergej Stepanov <Sergej.Stepanov@ids.de>
To: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH v2] using mii-bitbang on different processor ports
Date: Wed, 31 Oct 2007 08:30:58 +0100 [thread overview]
Message-ID: <1193815858.2678.2.camel@p60635-ste.ids.de> (raw)
In-Reply-To: <472776AE.2060009@freescale.com>
Am Dienstag, den 30.10.2007, 13:23 -0500 schrieb Scott Wood:
> Sergej Stepanov wrote:
> > + if( !of_address_to_resource(np, 1, &res[1])) {
>
> The spacing is still wrong.
>
> > - iounmap(bitbang->dir);
> > + if ( bitbang->mdio.dir != bitbang->mdc.dir)
> > + iounmap(bitbang->mdio.dir);
> > + iounmap(bitbang->mdc.dir);
>
> And here.
>
> -Scott
Oh, sorry.
--
Sergej I. Stepanov
E-PA
IDS GmbH
Nobelstr. 18, Zim. 2.1.05
D-76275 Ettlingen
T +49 (0) 72 43/2 18-615
F +49 (0) 72 43/2 18-400
Email: <Sergej.Stepanov@ids.de>
<http://www.ids.de>
Geschäftsführer: Norbert Wagner, Friedrich Abriß
Sitz der Gesellschaft: Ettlingen
Amtsgericht Mannheim HRB 362503
prev parent reply other threads:[~2007-10-31 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 18:10 [PATCH v2] using mii-bitbang on different processor ports Sergej Stepanov
2007-10-30 18:23 ` Scott Wood
2007-10-31 7:30 ` Sergej Stepanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193815858.2678.2.camel@p60635-ste.ids.de \
--to=sergej.stepanov@ids.de \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).