From: Chris Poon <dev-null@telus.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
jeff@garzik.org
Subject: Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames
Date: Thu, 1 Nov 2007 13:52:13 -0700 [thread overview]
Message-ID: <1193950333.472a3c7d30c3d@webmail.telus.net> (raw)
In-Reply-To: <20071101121239.d0e67bd3.akpm@linux-foundation.org>
Forgot to add that only changing BMAC_TXMAX & BMAC_RXMAX wouldn't work
for me, until I changed 2 skb_put as well (which is in the patch that
I submitted in bugzilla). Dug up some really old threads on the net
and found out that this was reported before
Quoting Andrew Morton <akpm@linux-foundation.org>:
> On Wed, 31 Oct 2007 16:35:57 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Date: Wed, 31 Oct 2007 15:43:01 -0700
> >
> > > > sunhme requires lower MTU to handle 802.1q frames - even though the
> PCI
> > > > driver supported VLAN tagging, you cannot do full MTU @ 1500 because
> the
> > > > driver doesn't set the card to transfer more the extra bytes for a
> 802.1q
> > > > frame at 1500 MTU.
> >
> > It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
> > flag should be set both in the PCI and non-PCI cases.
> >
> > Jeff, please apply, thanks:
> >
> > [SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
> >
> > No HME parts can do VLANs correctly.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
> > index 120c8af..c20a3bd 100644
> > --- a/drivers/net/sunhme.c
> > +++ b/drivers/net/sunhme.c
> > @@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct
> pci_dev *pdev,
> > dev->irq = pdev->irq;
> > dev->dma = 0;
> >
> > - /* Happy Meal can do it all... */
> > - dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> > + /* Happy Meal can do it all... except VLAN. */
> > + dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
> >
> > #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
> > /* Hook up PCI register/dma accessors. */
>
> I forgot to add my standard "please reply via emailed reply-to-all, not via
> the bugzilla web interface", so Chris has gone and attempted to communicate
> with us via the bugzilla UI (sigh).
>
> He asked
>
> "Even though it appears to work after I bumped the BMAC_TXMAX / BMAC_RXMAX?"
>
>
>
prev parent reply other threads:[~2007-11-01 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9270-10286@http.bugzilla.kernel.org/>
2007-10-31 22:43 ` [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames Andrew Morton
2007-10-31 23:35 ` David Miller
2007-11-01 19:12 ` Andrew Morton
2007-11-01 20:52 ` Chris Poon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193950333.472a3c7d30c3d@webmail.telus.net \
--to=dev-null@telus.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).