[PATCH]iwlwifi not correctly dealing with hotunplug

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH]iwlwifi not correctly dealing with hotunplug
@ 2007-11-13 11:49 Oliver Neukum
  2007-11-13 15:37 ` Dan Williams
  0 siblings, 1 reply; 5+ messages in thread
From: Oliver Neukum @ 2007-11-13 11:49 UTC (permalink / raw)
  To: David Miller, netdev

It makes no sense to enable interrupts if a device has been unplugged.
In addition if in doubt IRQ_HANDLED should be returned.

Signed-off-by: Oliver Neukum <oneukum@suse.de>

	Regards
		Oliver

----

--- linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c.alt	2007-11-13 12:23:07.000000000 +0100
+++ linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c	2007-11-13 12:26:00.000000000 +0100
@@ -4850,7 +4850,7 @@ static irqreturn_t iwl_isr(int irq, void
 	if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
 		/* Hardware disappeared */
 		IWL_WARNING("HARDWARE GONE?? INTA == 0x%080x\n", inta);
-		goto none;
+		goto unplugged;
 	}
 
 	IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
@@ -4858,6 +4858,7 @@ static irqreturn_t iwl_isr(int irq, void
 
 	/* iwl_irq_tasklet() will service interrupts and re-enable them */
 	tasklet_schedule(&priv->irq_tasklet);
+unplugged:
 	spin_unlock(&priv->lock);
 
 	return IRQ_HANDLED;

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH]iwlwifi not correctly dealing with hotunplug
  2007-11-13 11:49 [PATCH]iwlwifi not correctly dealing with hotunplug Oliver Neukum
@ 2007-11-13 15:37 ` Dan Williams
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Williams @ 2007-11-13 15:37 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: netdev

On Tue, 2007-11-13 at 12:49 +0100, Oliver Neukum wrote:
> It makes no sense to enable interrupts if a device has been unplugged.
> In addition if in doubt IRQ_HANDLED should be returned.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

Might want to forward to linux-wireless@ ?  And maybe cc the ipw2100@
sourceforge upstream lists too.

Dan

> 	Regards
> 		Oliver
> 
> ----
> 
> --- linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c.alt	2007-11-13 12:23:07.000000000 +0100
> +++ linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c	2007-11-13 12:26:00.000000000 +0100
> @@ -4850,7 +4850,7 @@ static irqreturn_t iwl_isr(int irq, void
>  	if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
>  		/* Hardware disappeared */
>  		IWL_WARNING("HARDWARE GONE?? INTA == 0x%080x\n", inta);
> -		goto none;
> +		goto unplugged;
>  	}
>  
>  	IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
> @@ -4858,6 +4858,7 @@ static irqreturn_t iwl_isr(int irq, void
>  
>  	/* iwl_irq_tasklet() will service interrupts and re-enable them */
>  	tasklet_schedule(&priv->irq_tasklet);
> +unplugged:
>  	spin_unlock(&priv->lock);
>  
>  	return IRQ_HANDLED;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH]iwlwifi not correctly dealing with hotunplug
@ 2007-11-13 18:26 Oliver Neukum
       [not found] ` <200711131926.53732.oneukum-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Oliver Neukum @ 2007-11-13 18:26 UTC (permalink / raw)
  To: David Miller, netdev-u79uwXL29TY76Z2rM5mHXA,
	ipw2100-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Dan Williams,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA

It makes no sense to enable interrupts if a device has been unplugged.
In addition if in doubt IRQ_HANDLED should be returned.

Signed-off-by: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>

	Regards
		Oliver

----

--- linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c.alt	2007-11-13 12:23:07.000000000 +0100
+++ linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c	2007-11-13 12:26:00.000000000 +0100
@@ -4850,7 +4850,7 @@ static irqreturn_t iwl_isr(int irq, void
 	if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
 		/* Hardware disappeared */
 		IWL_WARNING("HARDWARE GONE?? INTA == 0x%080x\n", inta);
-		goto none;
+		goto unplugged;
 	}
 
 	IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
@@ -4858,6 +4858,7 @@ static irqreturn_t iwl_isr(int irq, void
 
 	/* iwl_irq_tasklet() will service interrupts and re-enable them */
 	tasklet_schedule(&priv->irq_tasklet);
+unplugged:
 	spin_unlock(&priv->lock);
 
 	return IRQ_HANDLED;

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <200711131926.53732.oneukum-l3A5Bk7waGM@public.gmane.org>]

* Re: [PATCH]iwlwifi not correctly dealing with hotunplug
       [not found] ` <200711131926.53732.oneukum-l3A5Bk7waGM@public.gmane.org>
@ 2007-11-14  1:30   ` Zhu Yi
  2007-11-14  5:10     ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Zhu Yi @ 2007-11-14  1:30 UTC (permalink / raw)
  To: Oliver Neukum, John W.Linville
  Cc: David Miller, netdev-u79uwXL29TY76Z2rM5mHXA,
	ipw2100-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Dan Williams,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA


On Tue, 2007-11-13 at 19:26 +0100, Oliver Neukum wrote:
> It makes no sense to enable interrupts if a device has been unplugged.
> In addition if in doubt IRQ_HANDLED should be returned.
> 
> Signed-off-by: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>

ACK. Could you also do the same for iwl4965? Or John, do you mind to
get the full patch from our GIT (with a little directory twick for the
filename in the patch).

http://intellinuxwireless.org/repos/?p=iwlwifi.git;a=commitdiff_plain;h=96f1d448523930a04b3c81067c1cfafe56cc3768;hp=2355f9930372953d41ee884ea6bf1535d0b09099

Thanks,
-yi

> ----
> 
> --- linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c.alt	2007-11-13 12:23:07.000000000 +0100
> +++ linux-2.6.24-rc1/drivers/net/wireless/iwlwifi/iwl3945-base.c	2007-11-13 12:26:00.000000000 +0100
> @@ -4850,7 +4850,7 @@ static irqreturn_t iwl_isr(int irq, void
>  	if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
>  		/* Hardware disappeared */
>  		IWL_WARNING("HARDWARE GONE?? INTA == 0x%080x\n", inta);
> -		goto none;
> +		goto unplugged;
>  	}
>  
>  	IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
> @@ -4858,6 +4858,7 @@ static irqreturn_t iwl_isr(int irq, void
>  
>  	/* iwl_irq_tasklet() will service interrupts and re-enable them */
>  	tasklet_schedule(&priv->irq_tasklet);
> +unplugged:
>  	spin_unlock(&priv->lock);
>  
>  	return IRQ_HANDLED;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH]iwlwifi not correctly dealing with hotunplug
  2007-11-14  1:30   ` Zhu Yi
@ 2007-11-14  5:10     ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2007-11-14  5:10 UTC (permalink / raw)
  To: yi.zhu; +Cc: oneukum, linville, netdev, ipw2100-devel, dcbw, linux-wireless

From: Zhu Yi <yi.zhu@intel.com>
Date: Wed, 14 Nov 2007 09:30:54 +0800

> 
> On Tue, 2007-11-13 at 19:26 +0100, Oliver Neukum wrote:
> > It makes no sense to enable interrupts if a device has been unplugged.
> > In addition if in doubt IRQ_HANDLED should be returned.
> > 
> > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> 
> ACK.

I've applied Olver's patch, thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-11-14  5:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-13 11:49 [PATCH]iwlwifi not correctly dealing with hotunplug Oliver Neukum
2007-11-13 15:37 ` Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2007-11-13 18:26 Oliver Neukum
     [not found] ` <200711131926.53732.oneukum-l3A5Bk7waGM@public.gmane.org>
2007-11-14  1:30   ` Zhu Yi
2007-11-14  5:10     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).