From: Joe Perches <joe@perches.com>
To: Oliver Hartkopp <oliver@hartkopp.net>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
Urs Thuermann <urs.thuermann@gmx.de>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Urs Thuermann <urs.thuermann@volkswagen.de>,
Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module
Date: Thu, 15 Nov 2007 00:04:20 -0800 [thread overview]
Message-ID: <1195113860.27113.34.camel@localhost> (raw)
In-Reply-To: <473BF7FD.7010403@hartkopp.net>
On Thu, 2007-11-15 at 08:40 +0100, Oliver Hartkopp wrote:
> Stephen Hemminger wrote:
> >> +#ifdef CONFIG_CAN_DEBUG_CORE
> >> +extern void can_debug_skb(struct sk_buff *skb);
> >> +extern void can_debug_cframe(const char *msg, struct can_frame *cframe);
> >> +#define DBG(fmt, args...) (DBG_VAR & 1 ? printk( \
> >> + KERN_DEBUG DBG_PREFIX ": %s: " fmt, \
> >> + __func__, ##args) : 0)
> >> +#define DBG_FRAME(fmt, cf) (DBG_VAR & 2 ? can_debug_cframe(fmt, cf) : 0)
> >> +#define DBG_SKB(skb) (DBG_VAR & 4 ? can_debug_skb(skb) : 0)
> >> +#else
> >> +#define DBG(fmt, args...)
> >> +#define DBG_FRAME(fmt, cf)
> >> +#define DBG_SKB(skb)
> >> +#endif
I would prefer the more frequently used macro style:
#define DBG(fmt, args...) \
do { if (DBG_VAR & 1) printk(KERN_DEBUG DBG_PREFIX ": %s: " fmt, \
__func__, ##args); } while (0)
#define DBG_FRAME(fmt, cf) \
do { if (DBG_VAR & 2) can_debug_cframe(fmt, cf); } while (0)
#define DBG_SKB(skb) \
do { if (DBG_VAR & 4) can_debug_skb(skb); } while (0)
next prev parent reply other threads:[~2007-11-15 8:04 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 12:13 [PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25 Urs Thuermann
2007-11-14 12:13 ` [PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN Urs Thuermann
2007-11-14 12:13 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-11-14 21:38 ` Stephen Hemminger
2007-11-15 7:40 ` Oliver Hartkopp
2007-11-15 8:04 ` Joe Perches [this message]
2007-11-15 11:51 ` Urs Thuermann
2007-11-15 12:05 ` David Miller
2007-11-15 15:11 ` Sam Ravnborg
2007-11-16 14:33 ` Urs Thuermann
2007-11-16 23:42 ` David Miller
2007-11-15 11:36 ` Urs Thuermann
2007-11-15 15:09 ` Sam Ravnborg
2007-11-14 12:13 ` [PATCH 3/7] CAN: Add raw protocol Urs Thuermann
2007-11-14 12:13 ` [PATCH 4/7] CAN: Add broadcast manager (bcm) protocol Urs Thuermann
2007-11-14 12:13 ` [PATCH 5/7] CAN: Add virtual CAN netdevice driver Urs Thuermann
2007-11-14 12:51 ` Patrick McHardy
2007-11-14 13:36 ` Urs Thuermann
2007-11-14 13:45 ` Patrick McHardy
2007-11-14 12:13 ` [PATCH 6/7] CAN: Add maintainer entries Urs Thuermann
2007-11-14 12:13 ` [PATCH 7/7] CAN: Add documentation Urs Thuermann
-- strict thread matches above, loose matches on Subject: below --
2007-11-16 15:02 [PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25, update Urs Thuermann
2007-11-16 15:02 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-10-05 10:49 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #10 Urs Thuermann
2007-10-05 10:49 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-10-02 13:10 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #9 Urs Thuermann
2007-10-02 13:10 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-10-02 14:38 ` Arnaldo Carvalho de Melo
2007-10-02 16:09 ` Oliver Hartkopp
2007-10-04 11:51 ` Urs Thuermann
2007-10-04 13:40 ` Arnaldo Carvalho de Melo
2007-09-25 12:20 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #8 Urs Thuermann
2007-09-25 12:20 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-25 12:41 ` Arnaldo Carvalho de Melo
2007-09-25 13:24 ` Urs Thuermann
2007-09-25 15:33 ` Stephen Hemminger
2007-09-25 21:00 ` Urs Thuermann
2007-09-25 21:07 ` Stephen Hemminger
2007-09-25 21:09 ` David Miller
2007-09-28 16:27 ` Thomas Gleixner
2007-09-28 20:20 ` David Miller
2007-09-28 20:28 ` Thomas Gleixner
2007-09-20 18:43 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #7 Urs Thuermann
2007-09-20 18:43 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-20 20:06 ` Joe Perches
2007-09-20 20:27 ` Thomas Gleixner
2007-09-21 10:35 ` Urs Thuermann
2007-09-21 16:58 ` Joe Perches
2007-09-24 19:23 ` Urs Thuermann
2007-09-21 12:47 ` Patrick McHardy
2007-09-21 18:01 ` Urs Thuermann
2007-09-22 10:53 ` Patrick McHardy
2007-09-17 10:03 [PATCH 0/7] CAN: Add new PF_CAN protocol family, try #6 Urs Thuermann
2007-09-17 10:03 ` [PATCH 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-09-17 15:50 ` Paul E. McKenney
2007-09-18 13:31 ` Patrick McHardy
2007-09-18 14:54 ` Urs Thuermann
2007-09-18 15:07 ` Patrick McHardy
2007-09-18 21:20 ` Urs Thuermann
2007-09-19 8:27 ` Patrick McHardy
2007-09-20 8:53 ` Urs Thuermann
2007-09-20 10:33 ` Patrick McHardy
2007-09-20 11:30 ` Urs Thuermann
2007-09-20 11:43 ` Patrick McHardy
2007-08-04 2:06 [patch 0/7] CAN: Add new PF_CAN protocol family, try #5 Urs Thuermann
2007-08-04 2:06 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-06-22 3:44 [patch 0/7] CAN: Add new PF_CAN protocol family, try #3 Urs Thuermann
2007-06-22 3:44 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-30 13:11 [patch 0/7] CAN: Add new PF_CAN protocol family, update Urs Thuermann
2007-05-30 13:11 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-16 14:51 [patch 0/7] CAN: Add new PF_CAN protocol family Urs Thuermann
2007-05-16 14:51 ` [patch 2/7] CAN: Add PF_CAN core module Urs Thuermann
2007-05-16 16:35 ` Arnaldo Carvalho de Melo
2007-05-16 19:14 ` Urs Thuermann
2007-05-16 20:51 ` Arnaldo Carvalho de Melo
2007-05-18 0:59 ` Paul E. McKenney
2007-05-18 9:19 ` Oliver Hartkopp
2007-05-18 14:33 ` Paul E. McKenney
2007-05-18 15:03 ` Oliver Hartkopp
2007-05-18 21:06 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195113860.27113.34.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=oliver@hartkopp.net \
--cc=shemminger@linux-foundation.org \
--cc=urs.thuermann@gmx.de \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).