From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: dlstevens@us.ibm.com, jmorris@namei.org, kaber@coreworks.de,
kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org, pekkas@netcore.fi,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions
Date: Mon, 19 Nov 2007 21:59:58 -0800 [thread overview]
Message-ID: <1195538398.4675.86.camel@localhost> (raw)
In-Reply-To: <20071119.214655.247082473.davem@davemloft.net>
On Mon, 2007-11-19 at 21:46 -0800, David Miller wrote:
> I would also change the names, it's a better idea to prefix the
> names with a namespace for the stuff being operated on, therefore
> I'd prefer names like "ipv4_is_loopback()" etc.
I used:
+static inline bool is_ip4_loopback(__be32 addr)
and converted the current uses in net of macros
to use those functions directly. I'd prefer to drop
the macros entirely, but there are uses in
drivers/infiniband and drivers/parisc to convert too.
> I'm dropping these patches for now.
Is the use of "is_ip4_<level>" not "ipv4_is_<level>"
your reason to drop the patches?
next prev parent reply other threads:[~2007-11-20 6:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 15:53 [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions Joe Perches
2007-11-14 16:53 ` David Stevens
2007-11-15 1:54 ` Joe Perches
2007-11-15 2:09 ` Joe Perches
2007-11-20 5:46 ` David Miller
2007-11-20 5:59 ` Joe Perches [this message]
2007-11-20 6:18 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-11-20 6:41 Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195538398.4675.86.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).