public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	netdev <netdev@vger.kernel.org>,
	bridge <bridge@linux-foundation.org>
Subject: Re: [Bridge] Re: [RFC] bridging: don't forward EAPOL frames
Date: Tue, 27 Nov 2007 16:28:41 +0100	[thread overview]
Message-ID: <1196177321.6058.30.camel@johannes.berg> (raw)
In-Reply-To: <bdfc5d6e0711270724i3ce7cf41lb5f01dd5dcac98f9@mail.gmail.com> (sfid-20071127_152407_326070_3E3E1011)

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]


> > > Not needed because the bridge is already handling it:
> > >
> > > 1) If running STP (ie true bridge), then all link local multicast is only received by
> > > the bridge and never forwarded.
> >
> > Well, typical access point setups bridge the wireless AP interface with
> > wired, EAPOL frames can be unicast (and 802.11 specifies to do so) and
> > we want to avoid having them unicast to another host.
> >
> > Also, 802.1X in C.3.3 recommends not bridging the *ethertype* rather
> > than depending on the link-local multicast address because otherwise
> > eapol frames can be unicast into the network behind the (authorized)
> > port which is undesirable.

> I agree with Stephen, that based on the way it's likely people use
> linux bridges it seems like this is something that could be configured
> rather than simply dropping those frames without any chance to forward
> them.

Well Stephen is wrong in one thing that eapol need not be link local
multicast for 802.11, it's unicast there so the dropping of link local
packets doesn't help.

> There are probably quite a few people out there who will not
> expect this change, so it should be easy to change during runtime.

I'm not aware of any use for EAPOL frames traversing the network. I'm
also not aware of any proper 802.1X implementation for linux bridges but
I didn't do too much research yet. I don't see why people would rely on
EAPOL frames being bridged when the protocol is by definition local to a
link.

> Don't forget that a simple ebtables rule could also drop EAPOL if needed.

Indeed, but I'd prefer the bridge to do the right thing in absence of
configuration.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2007-11-27 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22 13:23 [RFC] bridging: don't forward EAPOL frames Johannes Berg
2007-11-26 17:36 ` Stephen Hemminger
2007-11-27 13:24   ` Johannes Berg
2007-11-27 15:24     ` [Bridge] " Andy Gospodarek
2007-11-27 15:28       ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196177321.6058.30.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=andy@greyhouse.net \
    --cc=bridge@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox