2.6.23-mm1 tg3 wake-on-lan oddity...

2.6.23-mm1 tg3 wake-on-lan oddity...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Scenario - Dell Latitude D820 laptop, tg3 driver says this at boot:

eth0: Tigon3 [partno(BCM5752KFBG) rev 6002 PHY(5752)] (PCI Express) 10/100/1000Base-T Ethernet 00:15:c5:c8:33:4e
eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] WireSpeed[1] TSOcap[1]
eth0: dma_rwctrl[76180000] dma_mask[64-bit]

# (lspci; lspci -n) | grep 09
09:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5752 Gigabit Ethernet PCI Express (rev 02)
09:00.0 0200: 14e4:1600 (rev 02)

(I think that's most of the likely-relevant info...)

Issue:

I (for unrelated reasons) run powertop, and it suggests I conserve power
by doing 'ethtool -s eth0 wol d'.  I look at it, and think that it's daft,
because (a) the Dell factory default is WOL disabled and (b) if it wasn't
the default, I'd have *set* it to disabled, and (c) I even went back and
rebooted and checked the BIOS setting - disabled. Nonetheless:

# ethtool eth0 | grep Wake
        Supports Wake-on: g
        Wake-on: g

Is this expected behavior?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

[Michael Chan]

Valdis.Kletnieks@vt.edu wrote:

> (a) the Dell factory default is WOL disabled and (b) 
> if it wasn't
> the default, I'd have *set* it to disabled, and (c) I even 
> went back and
> rebooted and checked the BIOS setting - disabled. Nonetheless:
> 
> # ethtool eth0 | grep Wake
>         Supports Wake-on: g
>         Wake-on: g
> 
> Is this expected behavior?
> 

The new tg3 is supposed to follow the WoL setting in the
NVRAM, so this is not expected.  We'll have to look into
this.

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

On Tue, 27 Nov 2007 08:04:28 PST, Michael Chan said:
> Valdis.Kletnieks@vt.edu wrote:
> 
> > (a) the Dell factory default is WOL disabled and (b)
> > if it wasn't
> > the default, I'd have *set* it to disabled, and (c) I even
> > went back and
> > rebooted and checked the BIOS setting - disabled. Nonetheless:
> >
> > # ethtool eth0 | grep Wake
> >         Supports Wake-on: g
> >         Wake-on: g
> >
> > Is this expected behavior?
> >
> 
> The new tg3 is supposed to follow the WoL setting in the
> NVRAM, so this is not expected.  We'll have to look into
> this.

Any info that would help?  printk's to stick in tg3.c?  Dumping the
relevant bytes of NVRAM? etc?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

[Michael Chan]

On Tue, 2007-11-27 at 01:35 -0800, Valdis.Kletnieks@vt.edu wrote:

> 
> Issue:
> 
> I (for unrelated reasons) run powertop, and it suggests I conserve power
> by doing 'ethtool -s eth0 wol d'.  I look at it, and think that it's daft,
> because (a) the Dell factory default is WOL disabled and (b) if it wasn't
> the default, I'd have *set* it to disabled, and (c) I even went back and
> rebooted and checked the BIOS setting - disabled. Nonetheless:
> 
> # ethtool eth0 | grep Wake
>         Supports Wake-on: g
>         Wake-on: g
> 
> Is this expected behavior?

What's happening is that there are 2 WoL settings: one in the BIOS and
one in the NIC's NVRAM.  For WoL to work, I think both settings have to
be enabled.  Apparently in this case, when you turn off WoL in the BIOS,
the NVRAM's WoL setting is unchanged, and will be seen by tg3 as
enabled.

Ideally, the BIOS should modify the NVRAM's setting when it is changed.
We will talk to Dell to get their opinion on this as this is very
confusing to the user.

Thanks.

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On Tue, 27 Nov 2007 13:34:57 PST, Michael Chan said:

> Ideally, the BIOS should modify the NVRAM's setting when it is changed.
> We will talk to Dell to get their opinion on this as this is very
> confusing to the user.

That would certainly explain what I'm seeing, and I can certainly wait
if the answer is indeed "Buggy BIOS, fixed in D820 A08 or A09 or whenever".
(If Dell cares, I'm at BIOS A07 already).

In the meantime, I just stuck an 'ethtool -s eth0 wol d' in /etc/rc.local
until a proper fix shows up.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]