From: Joe Perches <joe@perches.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [NETLINK]: af_netlink.c checkpatch cleanups
Date: Tue, 04 Dec 2007 09:21:03 -0800 [thread overview]
Message-ID: <1196788863.4898.13.camel@localhost> (raw)
In-Reply-To: <47550AA8.3030608@trash.net>
On Tue, 2007-12-04 at 09:07 +0100, Patrick McHardy wrote:
> [NETLINK]: af_netlink.c checkpatch cleanups
> -static __inline__ void
> +static inline void
> netlink_lock_table(void)
> {
> /* read_lock() synchronizes us to netlink_table_grab */
> @@ -208,14 +208,15 @@ netlink_lock_table(void)
> read_unlock(&nl_table_lock);
> }
>
> -static __inline__ void
> +static inline void
> netlink_unlock_table(void)
> {
> if (atomic_dec_and_test(&nl_table_users))
> wake_up(&nl_table_wait);
> }
>
> -static __inline__ struct sock *netlink_lookup(struct net *net, int protocol, u32 pid)
> +static inline struct sock *netlink_lookup(struct net *net, int protocol,
> + u32 pid)
netlink_lock_table and netlink_unlock_table are the only
function definitions in this patch that have newlines between
function type and function name.
Perhaps checkpatch should warn on newlines between function type
and function names.
prev parent reply other threads:[~2007-12-04 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 8:07 [NETLINK]: af_netlink.c checkpatch cleanups Patrick McHardy
2007-12-04 8:13 ` Herbert Xu
2007-12-04 8:20 ` David Miller
2007-12-04 17:21 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196788863.4898.13.camel@localhost \
--to=joe@perches.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).