From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: jeff@garzik.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Sorbica Shieh <sorbica@icplus.com.tw>,
Jesse Huang <jesse@icplus.com.tw>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: Pull request for 'ipg' branch
Date: Tue, 04 Dec 2007 14:14:55 -0800 [thread overview]
Message-ID: <1196806495.10819.16.camel@localhost> (raw)
In-Reply-To: <20071204214551.GA6345@electric-eye.fr.zoreil.com>
On Tue, 2007-12-04 at 22:45 +0100, Francois Romieu wrote:
> diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
> index dbd23bb..f736c35 100644
> --- a/drivers/net/ipg.c
> +++ b/drivers/net/ipg.c
> -MODULE_DESCRIPTION("IC Plus IP1000 Gigabit Ethernet Adapter Linux Driver "
> - DrvVer);
> +MODULE_DESCRIPTION("IC Plus IP1000 Gigabit Ethernet Adapter Linux Driver");
> MODULE_LICENSE("GPL");
> - if ((sp->LED_Mode & 0x01) == 1)
> + if ((sp->led_mode & 0x01) == 1)
I think the use of hex and decimal constants is odd.
I think "if (sp->led_mode & 0x01)" is better.
> diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
> index d5d092c..cda5388 100644
> --- a/drivers/net/ipg.h
> +++ b/drivers/net/ipg.h
> /* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
> -#define IPG_APPEND_FCS_ON_TX TRUE
> +#define IPG_APPEND_FCS_ON_TX 1
Why not true and false?
> @@ -753,8 +732,7 @@ enum ipg_regs {
> * Miscellaneous macros.
> */
>
> -/* Marco for printing debug statements.
> -# define IPG_DDEBUG_MSG(args...) printk(KERN_DEBUG "IPG: " ## args) */
> +/* Marco for printing debug statements. */
Macros
cheers, Joe
next prev parent reply other threads:[~2007-12-04 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 21:45 Pull request for 'ipg' branch Francois Romieu
2007-12-04 22:14 ` Joe Perches [this message]
2007-12-05 21:51 ` Francois Romieu
2007-12-17 23:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196806495.10819.16.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jesse@icplus.com.tw \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=romieu@fr.zoreil.com \
--cc=sorbica@icplus.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).