From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros
Date: Sun, 16 Dec 2007 20:01:06 -0800 [thread overview]
Message-ID: <1197864066.4894.20.camel@localhost> (raw)
In-Reply-To: <20071216.134825.261226998.davem@davemloft.net>
On Sun, 2007-12-16 at 13:48 -0800, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Thu, 13 Dec 2007 15:39:01 -0800
> > Signed-off-by: Joe Perches <joe@perches.com>
> Applied, thanks for doing this work Joe.
I broke the parisc build. Bad Joe...
Here's the patch:
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index a6d6b24..703b85e 100644
--- a/drivers/parisc/led.c
+++ b/drivers/parisc/led.c
@@ -364,7 +364,7 @@ static __inline__ int led_get_net_activity(void)
struct in_device *in_dev = __in_dev_get_rcu(dev);
if (!in_dev || !in_dev->ifa_list)
continue;
- if (LOOPBACK(in_dev->ifa_list->ifa_local))
+ if (ipv4_is_loopback(in_dev->ifa_list->ifa_local))
continue;
stats = dev->get_stats(dev);
rx_total += stats->rx_packets;
next prev parent reply other threads:[~2007-12-17 4:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e2ebcbf24539c0a3ef2ac77147dbfa55d8ac9e33.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 1/8] Create ipv4_is_<type>(__be32 addr) functions Joe Perches
2007-12-16 21:42 ` David Miller
2007-12-17 22:37 ` Jan Engelhardt
2007-12-17 22:41 ` David Miller
2007-12-17 22:42 ` Joe Perches
2007-12-17 22:43 ` David Miller
2007-12-17 23:02 ` Jan Engelhardt
2007-12-13 23:38 ` Joe Perches
[not found] ` <40bae850207de9257479a535ea5ab4e7d1cdeab5.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 2/8] include/net: Use ipv4_is_<type> Joe Perches
2007-12-16 21:43 ` David Miller
[not found] ` <63aaea4664a57e3b9a0b7454da94e72b6d462e22.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 3/8] net/core: " Joe Perches
2007-12-16 21:44 ` David Miller
[not found] ` <9ab25b88c4c02bb7ba14ff68a8e99bdf4bdef9dd.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 4/8] net/ipv4: " Joe Perches
2007-12-16 21:45 ` David Miller
[not found] ` <350bda1cfd4ac57b354451157b9009b3c8ce334e.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 5/8] net/netfilter: " Joe Perches
2007-12-13 23:38 ` Joe Perches
2007-12-13 23:38 ` Joe Perches
2007-12-16 21:46 ` David Miller
[not found] ` <1bb329b93a1f75766b7b89afdfa5ae673e9355ec.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` [PATCH net-2.6.25 6/8] sctp: " Joe Perches
2007-12-14 19:11 ` Vlad Yasevich
2007-12-14 19:14 ` David Miller
2007-12-14 19:17 ` Vlad Yasevich
2007-12-16 21:47 ` David Miller
[not found] ` <aaf1cd18672fdabaa410bff09200c6a74534bdb0.1197432867.git.joe@perches.com>
2007-12-13 23:39 ` [PATCH net-2.6.25 7/8] drivers/infiniband: " Joe Perches
2007-12-13 23:39 ` [ofa-general] " Joe Perches
2007-12-16 21:47 ` David Miller
[not found] ` <885ea24008e2b1c07e6bff0344f260a0ff104a35.1197432867.git.joe@perches.com>
2007-12-13 23:39 ` [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros Joe Perches
2007-12-16 21:48 ` David Miller
2007-12-17 4:01 ` Joe Perches [this message]
2007-12-17 4:28 ` David Miller
2007-12-13 23:39 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197864066.4894.20.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).