From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5016BC43381 for ; Thu, 28 Mar 2019 18:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21B4E2082F for ; Thu, 28 Mar 2019 18:10:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cKOTu88S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbfC1SK2 (ORCPT ); Thu, 28 Mar 2019 14:10:28 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:43690 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfC1SK1 (ORCPT ); Thu, 28 Mar 2019 14:10:27 -0400 Received: by mail-pf1-f194.google.com with SMTP id c8so11705272pfd.10 for ; Thu, 28 Mar 2019 11:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jyg03ZaoyCeYM6VLSGu7sCj4mWv4bmg8tBugfs7+wzQ=; b=cKOTu88S+kxaxAvlLq3NSvZOswopflACQdNnVgPHwuICnlgoFQj75RPEjNRhtQGDXZ TVUhl94vaae9vfXV7sO8tkydOJTqM/qwodEpfbxCsfDjR6YDO2Kr8xHv5/bAdMG4nXFl ojuVc2fgT5xHY7vVhMoKOendF4xaSX/YNLpMd5DUjpQ87FJF7PQyYg6niAVVhVW+rBKU uLRqCDfqIQqWwStxWoI8gVJyYNK4Dq18C8e44Z+moXvZnTRFQF4ENRl4nRif65ZKTTqR 6vP5nunX0WcN+L60t8qdUH2hZ15LtrJixDiqH6tOrLlw3V2Psx7fo6kMxfrIxbEGapCQ p61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jyg03ZaoyCeYM6VLSGu7sCj4mWv4bmg8tBugfs7+wzQ=; b=CbB8XUHWTi4cacZUEfx+HhjBJO+tK9kjKHcOFklMUKIXPSz/adMXRH1dOmvdGS0peD Jb/Aoxm374ZE4eiB1IDsdQJHXI0L1KoqVlD822yMOW2lOTnlE3vS0CyfDcznF2TTlwJA XJG61YYvq52jO+WQIz+NLiUfK1/qBGsrjfGhLfR6ZpazTmGr0fvl6iSIGDfkXpvz/+Bu kmxunC66QD/yN+HeYisUeLEZYtDet573IOVVd2Vp6CCeuCCYgxcRGLo3TR6LRv3kd5Wz 1h/gfvg6csgUUFqgXPjVP9ky+PDsDm9tF7Wpxhv5OHUtsI9PoJ0tuyw+tiw71am5EqYd vSJQ== X-Gm-Message-State: APjAAAV1VYeN+1fqPKMH0gwgFDN9/4FMY5pDNctVt4iKgkEhG4qctFGm rFl+YlrXeDGckDGrIPtv4IU= X-Google-Smtp-Source: APXvYqwhpUwuyJaxBOOVnUevjY9g3791W0CEx98QIr8y47Rr8lyFH7e439Ux5P0DMQkniqNE774zxQ== X-Received: by 2002:aa7:8083:: with SMTP id v3mr25737790pff.135.1553796627373; Thu, 28 Mar 2019 11:10:27 -0700 (PDT) Received: from ?IPv6:2601:284:8200:5cfb:456a:d99d:343c:d9a9? ([2601:284:8200:5cfb:456a:d99d:343c:d9a9]) by smtp.googlemail.com with ESMTPSA id h19sm48959795pfd.130.2019.03.28.11.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 11:10:26 -0700 (PDT) Subject: Re: [PATCH v3 net-next 13/13] net: Use common nexthop init and release helpers To: Alexei Starovoitov , David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com References: <20190328035358.4929-1-dsahern@kernel.org> <20190328035358.4929-14-dsahern@kernel.org> <20190328155027.rm6zfeece7wlhn2i@ast-mbp> From: David Ahern Message-ID: <1197eb44-5539-c35d-19ee-fc0c7503d1b8@gmail.com> Date: Thu, 28 Mar 2019 12:10:22 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190328155027.rm6zfeece7wlhn2i@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/28/19 9:50 AM, Alexei Starovoitov wrote: > > patch 5 isn't pretty still and you didn't answer my question > why pointer to fib6_flags is worse than duplicated check. fib6_flags (prefix flags) has nothing to do with a fib6_nh initialization, and I do want to add a 6th input argument for something that is used in only 1 of 2 paths and even the 1 path is a highly unlikely.