* BNX2 warning
@ 2007-12-21 4:39 David Miller
2007-12-21 18:34 ` Michael Chan
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2007-12-21 4:39 UTC (permalink / raw)
To: mchan; +Cc: netdev
[ misspelled netdev list first time, retrying... ]
Michael, please fix this, thanks :-)
drivers/net/bnx2.c: In function 'bnx2_init_napi':
drivers/net/bnx2.c:7329: warning: no return statement in function returning non-void
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: BNX2 warning
2007-12-21 4:39 BNX2 warning David Miller
@ 2007-12-21 18:34 ` Michael Chan
2007-12-21 23:05 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Michael Chan @ 2007-12-21 18:34 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Thu, 2007-12-20 at 20:39 -0800, David Miller wrote:
> Michael, please fix this, thanks :-)
>
> drivers/net/bnx2.c: In function 'bnx2_init_napi':
> drivers/net/bnx2.c:7329: warning: no return statement in function returning non-void
>
[BNX2]: Fix compiler warning.
Change bnx2_init_napi() to void.
Warning was noted by DaveM.
Signed-off-by: Michael Chan <mchan@broadcom.com>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index aef2a9a..94d1857 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -7313,7 +7313,7 @@ bnx2_bus_string(struct bnx2 *bp, char *str)
return str;
}
-static int __devinit
+static void __devinit
bnx2_init_napi(struct bnx2 *bp)
{
int i;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: BNX2 warning
2007-12-21 18:34 ` Michael Chan
@ 2007-12-21 23:05 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-12-21 23:05 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 21 Dec 2007 10:34:15 -0800
> [BNX2]: Fix compiler warning.
>
> Change bnx2_init_napi() to void.
>
> Warning was noted by DaveM.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-21 23:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-21 4:39 BNX2 warning David Miller
2007-12-21 18:34 ` Michael Chan
2007-12-21 23:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).