netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorge Dijkstra <bjd@jooz.net>
To: dbrownell@users.sourceforge.net
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing
Date: Sat, 22 Dec 2007 22:51:28 +0100	[thread overview]
Message-ID: <11983602953487-git-send-email-bjd@jooz.net> (raw)
In-Reply-To: <11983602942818-git-send-email-bjd@jooz.net>

Just as ActiveSync devices, some regular RNDIS devices also lack
the CDC descriptors (e.g. devices based on BCM4320 WLAN chip).
This patch hardwires the CDC descriptors for all RNDIS style devices
when they are missing.

Signed-off-by: Bjorge Dijkstra <bjd@jooz.net>
---
 drivers/net/usb/cdc_ether.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index a42acc3..97c17bb 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -228,15 +228,16 @@ next_desc:
 		buf += buf [0];
 	}
 
-	/* Microsoft ActiveSync based RNDIS devices lack the CDC descriptors,
-	 * so we'll hard-wire the interfaces and not check for descriptors.
+	/* Microsoft ActiveSync based and some regular RNDIS devices lack the
+	 * CDC descriptors, so we'll hard-wire the interfaces and not check
+	 * for descriptors.
 	 */
-	if (is_activesync(&intf->cur_altsetting->desc) && !info->u) {
+	if (rndis && !info->u) {
 		info->control = usb_ifnum_to_if(dev->udev, 0);
 		info->data = usb_ifnum_to_if(dev->udev, 1);
 		if (!info->control || !info->data) {
 			dev_dbg(&intf->dev,
-				"activesync: master #0/%p slave #1/%p\n",
+				"rndis: master #0/%p slave #1/%p\n",
 				info->control,
 				info->data);
 			goto bad_desc;
@@ -316,7 +317,6 @@ void usbnet_cdc_unbind(struct usbnet *dev, struct usb_interface *intf)
 }
 EXPORT_SYMBOL_GPL(usbnet_cdc_unbind);
 
-\f
 /*-------------------------------------------------------------------------
  *
  * Communications Device Class, Ethernet Control model
-- 
1.5.2.5


  reply	other threads:[~2007-12-22 21:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 21:51 [PATCH 0/8] RFC: Wireless Extensions for rndis_host Bjorge Dijkstra
2007-12-22 21:51 ` Bjorge Dijkstra [this message]
2007-12-23  0:49   ` [PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing David Brownell
2007-12-22 21:51 ` [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind Bjorge Dijkstra
     [not found]   ` <11983602953865-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  0:51     ` David Brownell
2007-12-22 21:51 ` [PATCH 6/8] [PATCH] Split up rndis_host.c Bjorge Dijkstra
2007-12-23  1:17   ` David Brownell
     [not found]     ` <20071223011707.1798C2360C6-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-01-02 20:13       ` Jussi Kivilinna
2008-01-08 11:19         ` David Brownell
     [not found]           ` <200801080319.23299.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-08 17:32             ` Johannes Berg
     [not found]               ` <1199813561.6762.13.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-08 18:49                 ` David Brownell
2008-01-17 20:40             ` Jussi Kivilinna
2007-12-22 21:51 ` [PATCH 7/8] Add Wireless Extensions to rndis_host Bjorge Dijkstra
     [not found]   ` <11983602951628-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  1:27     ` David Brownell
     [not found] ` <11983602942818-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-22 21:51   ` [PATCH 1/8] Fix sparse warning: returning void-valued expression Bjorge Dijkstra
     [not found]     ` <11983602952341-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  0:42       ` David Brownell
2007-12-22 21:51   ` [PATCH 4/8] [PATCH] Halt device if rndis_bind fails Bjorge Dijkstra
2007-12-23  0:54     ` David Brownell
2007-12-22 21:51   ` [PATCH 5/8] Fix rndis packet filter flags Bjorge Dijkstra
2007-12-23  1:06     ` David Brownell
2007-12-22 21:51   ` [PATCH 8/8] [PATCH] Use wlan device name for RNDIS wireless devices Bjorge Dijkstra
     [not found]     ` <11983602952006-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  1:30       ` David Brownell
2007-12-23  1:49   ` [PATCH 0/8] RFC: Wireless Extensions for rndis_host David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11983602953487-git-send-email-bjd@jooz.net \
    --to=bjd@jooz.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).