netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorge Dijkstra <bjd-a1rhEgazXTw@public.gmane.org>
To: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jussi Kivilinna <jussi.kivilinna-E01nCVcF24I@public.gmane.org>
Subject: [PATCH 5/8] Fix rndis packet filter flags.
Date: Sat, 22 Dec 2007 22:51:31 +0100	[thread overview]
Message-ID: <1198360295996-git-send-email-bjd@jooz.net> (raw)
In-Reply-To: <11983602942818-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>

From: Jussi Kivilinna <jussi.kivilinna-E01nCVcF24I@public.gmane.org>

RNDIS packet filter flags are not exactly the same as CDC flags
so we cannot reuse them.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna-E01nCVcF24I@public.gmane.org>
Signed-off-by: Bjorge Dijkstra <bjd-a1rhEgazXTw@public.gmane.org>
---
 drivers/net/usb/rndis_host.c |   23 ++++++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
index c686025..3c116f9 100644
--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c
@@ -256,6 +256,27 @@ struct rndis_keepalive_c {	/* IN (optionally OUT) */
 #define OID_GEN_MAXIMUM_FRAME_SIZE	ccpu2(0x00010106)
 #define OID_GEN_CURRENT_PACKET_FILTER	ccpu2(0x0001010e)
 
+/* packet filter bits used by OID_GEN_CURRENT_PACKET_FILTER */
+#define RNDIS_PACKET_TYPE_DIRECTED		ccpu2(0x00000001)
+#define RNDIS_PACKET_TYPE_MULTICAST		ccpu2(0x00000002)
+#define RNDIS_PACKET_TYPE_ALL_MULTICAST		ccpu2(0x00000004)
+#define RNDIS_PACKET_TYPE_BROADCAST		ccpu2(0x00000008)
+#define RNDIS_PACKET_TYPE_SOURCE_ROUTING	ccpu2(0x00000010)
+#define RNDIS_PACKET_TYPE_PROMISCUOUS		ccpu2(0x00000020)
+#define RNDIS_PACKET_TYPE_SMT			ccpu2(0x00000040)
+#define RNDIS_PACKET_TYPE_ALL_LOCAL		ccpu2(0x00000080)
+#define RNDIS_PACKET_TYPE_GROUP			ccpu2(0x00001000)
+#define RNDIS_PACKET_TYPE_ALL_FUNCTIONAL	ccpu2(0x00002000)
+#define RNDIS_PACKET_TYPE_FUNCTIONAL		ccpu2(0x00004000)
+#define RNDIS_PACKET_TYPE_MAC_FRAME		ccpu2(0x00008000)
+
+/* default filter used with RNDIS devices */
+#define RNDIS_DEFAULT_FILTER ( \
+	RNDIS_PACKET_TYPE_DIRECTED | \
+	RNDIS_PACKET_TYPE_BROADCAST | \
+	RNDIS_PACKET_TYPE_ALL_MULTICAST | \
+	RNDIS_PACKET_TYPE_PROMISCUOUS )
+
 /*
  * RNDIS notifications from device: command completion; "reverse"
  * keepalives; etc
@@ -551,7 +572,7 @@ static int rndis_bind(struct usbnet *dev, struct usb_interface *intf)
 	u.set->oid = OID_GEN_CURRENT_PACKET_FILTER;
 	u.set->len = ccpu2(4);
 	u.set->offset = ccpu2((sizeof *u.set) - 8);
-	*(__le32 *)(u.buf + sizeof *u.set) = ccpu2(DEFAULT_FILTER);
+	*(__le32 *)(u.buf + sizeof *u.set) = RNDIS_DEFAULT_FILTER;
 
 	retval = rndis_command(dev, u.header);
 	if (unlikely(retval < 0)) {
-- 
1.5.2.5

  parent reply	other threads:[~2007-12-22 21:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 21:51 [PATCH 0/8] RFC: Wireless Extensions for rndis_host Bjorge Dijkstra
2007-12-22 21:51 ` [PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing Bjorge Dijkstra
2007-12-23  0:49   ` David Brownell
2007-12-22 21:51 ` [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind Bjorge Dijkstra
     [not found]   ` <11983602953865-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  0:51     ` David Brownell
     [not found] ` <11983602942818-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-22 21:51   ` [PATCH 1/8] Fix sparse warning: returning void-valued expression Bjorge Dijkstra
     [not found]     ` <11983602952341-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  0:42       ` David Brownell
2007-12-22 21:51   ` [PATCH 4/8] [PATCH] Halt device if rndis_bind fails Bjorge Dijkstra
2007-12-23  0:54     ` David Brownell
2007-12-22 21:51   ` Bjorge Dijkstra [this message]
2007-12-23  1:06     ` [PATCH 5/8] Fix rndis packet filter flags David Brownell
2007-12-22 21:51   ` [PATCH 8/8] [PATCH] Use wlan device name for RNDIS wireless devices Bjorge Dijkstra
     [not found]     ` <11983602952006-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  1:30       ` David Brownell
2007-12-23  1:49   ` [PATCH 0/8] RFC: Wireless Extensions for rndis_host David Brownell
2007-12-22 21:51 ` [PATCH 6/8] [PATCH] Split up rndis_host.c Bjorge Dijkstra
2007-12-23  1:17   ` David Brownell
     [not found]     ` <20071223011707.1798C2360C6-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-01-02 20:13       ` Jussi Kivilinna
2008-01-08 11:19         ` David Brownell
     [not found]           ` <200801080319.23299.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-08 17:32             ` Johannes Berg
     [not found]               ` <1199813561.6762.13.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-08 18:49                 ` David Brownell
2008-01-17 20:40             ` Jussi Kivilinna
2007-12-22 21:51 ` [PATCH 7/8] Add Wireless Extensions to rndis_host Bjorge Dijkstra
     [not found]   ` <11983602951628-git-send-email-bjd-a1rhEgazXTw@public.gmane.org>
2007-12-23  1:27     ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1198360295996-git-send-email-bjd@jooz.net \
    --to=bjd-a1rhegazxtw@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jussi.kivilinna-E01nCVcF24I@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).