From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0 Date: Mon, 24 Dec 2007 11:30:37 -0500 Message-ID: <1198513837.4427.8.camel@localhost> References: <20071224160739.M84357@visp.net.lb> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Pablo Neira Ayuso To: Denys Fedoryshchenko Return-path: Received: from wa-out-1112.google.com ([209.85.146.182]:33363 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbXLXQaq (ORCPT ); Mon, 24 Dec 2007 11:30:46 -0500 Received: by wa-out-1112.google.com with SMTP id v27so2776374wah.23 for ; Mon, 24 Dec 2007 08:30:46 -0800 (PST) In-Reply-To: <20071224160739.M84357@visp.net.lb> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2007-24-12 at 18:07 +0200, Denys Fedoryshchenko wrote: > Hi, probably like this will be better? > Previous patch was not backward compatible. > > Btw i checked twice, name is changed from libipt_MARK to libxt_MARK. So > probably when you have tested this, your iproute2 was looking to old > libipt_MARK (iptables is not deleting old libraries on make install). > Grr. I tested with a different iptables target and thought the rest work in the same manner. iptables needs to be consistent. ----- lilsol:~# export IPTABLES_LIB_DIR=/root/iptables-1.4.0/extensions/ lilsol:~# tc actions add action ipt -j TOS --set-tos Maximize-Reliability tablename: mangle hook: NF_IP_POST_ROUTING target: TOS set Maximize-Reliability index 0 lilsol:~# tc actions ls action ipt action order 0: tablename: mangle hook: NF_IP_POST_ROUTING target TOS set Maximize-Reliability index 2 ref 1 bind 0 // the above is what i tested // below is what you did lilsol:~# tc actions add action ipt -j mark --set-mark 3 /root/iptables-1.4.0/extensions/: cannot read file data: Is a directory failed to find target mark bad action parsing parse_action: bad value (5:ipt)! Illegal "action" Command "add" is unknown, try "tc actions help". lilsol:~# ------------ Applying your patch .... Seems corrupt; let me fix it up, test it and resend it to Stephen. cheers, jamal