From: jamal <hadi@cyberus.ca>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0
Date: Mon, 24 Dec 2007 11:57:37 -0500 [thread overview]
Message-ID: <1198515457.4427.16.camel@localhost> (raw)
In-Reply-To: <1198513837.4427.8.camel@localhost>
I just submitted a tested, slightly reduced patch (example we dont need
to register matches) and it works as expected now. Thanks for the
excellent work Denys.
Pablo, below looks an oversight.
I think there are some libraries like the mark target need also to be
backward compatible.
cheers,
jamal
On Mon, 2007-24-12 at 11:30 -0500, jamal wrote:
> Grr. I tested with a different iptables target and thought the rest work
> in the same manner. iptables needs to be consistent.
>
> -----
> lilsol:~# export IPTABLES_LIB_DIR=/root/iptables-1.4.0/extensions/
> lilsol:~# tc actions add action ipt -j TOS --set-tos
> Maximize-Reliability
> tablename: mangle hook: NF_IP_POST_ROUTING
> target: TOS set Maximize-Reliability index 0
> lilsol:~# tc actions ls action ipt
>
> action order 0: tablename: mangle hook: NF_IP_POST_ROUTING
> target TOS set Maximize-Reliability
> index 2 ref 1 bind 0
> // the above is what i tested
> // below is what you did
> lilsol:~# tc actions add action ipt -j mark --set-mark 3
> /root/iptables-1.4.0/extensions/: cannot read file data: Is a directory
> failed to find target mark
>
> bad action parsing
> parse_action: bad value (5:ipt)!
> Illegal "action"
> Command "add" is unknown, try "tc actions help".
> lilsol:~#
> ------------
>
> Applying your patch ....
> Seems corrupt; let me fix it up, test it and resend it to Stephen.
>
> cheers,
> jamal
>
next prev parent reply other threads:[~2007-12-24 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 16:07 [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0 Denys Fedoryshchenko
2007-12-24 16:30 ` jamal
2007-12-24 16:57 ` jamal [this message]
2007-12-26 10:59 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198515457.4427.16.camel@localhost \
--to=hadi@cyberus.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).