[PATCH] Add Linksys WCF11 to hostap driver

[PATCH] Add Linksys WCF11 to hostap driver

[Marcin Juszkiewicz]

From: Marcin Juszkiewicz <openembedded@haerwu.biz>

Linksys WCF11 submitted by Ångström user.

"The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", "RevA",
0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194 
manfid: 0x0274, 0x3301

Signed-off-by: Marcin Juszkiewicz <openembedded@haerwu.biz>

---
 drivers/net/wireless/hostap/hostap_cs.c |    4 ++++
 1 file changed, 4 insertions(+)

--- linux-2.6.23.orig/drivers/net/wireless/hostap/hostap_cs.c
+++ linux-2.6.23/drivers/net/wireless/hostap/hostap_cs.c
@@ -887,10 +887,14 @@ static struct pcmcia_device_id hostap_cs
                "Ver. 1.00",
                0x5cd01705, 0x4271660f, 0x9d08ee12),
        PCMCIA_DEVICE_PROD_ID123(
                "corega", "WL PCCL-11", "ISL37300P",
                0xa21501a, 0x59868926, 0xc9049a39),
+       PCMCIA_DEVICE_PROD_ID1234(
+               "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
+               "RevA",
+               0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),
        PCMCIA_DEVICE_NULL
 };
 MODULE_DEVICE_TABLE(pcmcia, hostap_cs_ids);


-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

                    Resistance Is Useless! (If < 1 ohm)

Re: [PATCH] Add Linksys WCF11 to hostap driver

[Pavel Roskin]

Hello!

On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:

> +       PCMCIA_DEVICE_PROD_ID1234(
> +               "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
> +               "RevA",
> +               0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),

I would prefer that revisions are not used for card identification in
presence of the chip name.  It's not like RevB would need another driver
as long as "ISL37300P" is still a part of the PCMCIA ID.
PCMCIA_DEVICE_PROD_ID123 should be enough.

-- 
Regards,
Pavel Roskin

Re: [PATCH] Add Linksys WCF11 to hostap driver

[Marcin Juszkiewicz]

Dnia sobota, 29 grudnia 2007, Pavel Roskin napisał:
> Hello!
>
> On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:
> > +       PCMCIA_DEVICE_PROD_ID1234(
> > +               "The Linksys Group, Inc.", "Wireless Network CF
> > Card", "ISL37300P", +               "RevA",
> > +               0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),
>
> I would prefer that revisions are not used for card identification in
> presence of the chip name.  It's not like RevB would need another
> driver as long as "ISL37300P" is still a part of the PCMCIA ID.
> PCMCIA_DEVICE_PROD_ID123 should be enough.

OK - updated patch below:

From: Marcin Juszkiewicz <openembedded-sbG99h22wavzs492ZWNkEA@public.gmane.org>

Linksys WCF11 submitted by Ångström user.

"The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", "RevA",
0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194 
manfid: 0x0274, 0x3301

Signed-off-by: Marcin Juszkiewicz <openembedded-sbG99h22wavzs492ZWNkEA@public.gmane.org>

---
 drivers/net/wireless/hostap/hostap_cs.c |    3 +++
 1 file changed, 3 insertions(+)

--- linux-2.6.23.orig/drivers/net/wireless/hostap/hostap_cs.c
+++ linux-2.6.23/drivers/net/wireless/hostap/hostap_cs.c
@@ -887,10 +887,13 @@ static struct pcmcia_device_id hostap_cs
                "Ver. 1.00",
                0x5cd01705, 0x4271660f, 0x9d08ee12),
        PCMCIA_DEVICE_PROD_ID123(
                "corega", "WL PCCL-11", "ISL37300P",
                0xa21501a, 0x59868926, 0xc9049a39),
+       PCMCIA_DEVICE_PROD_ID1233(
+               "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
+               0xa5f472c2, 0x9c05598d, 0xc9049a39),
        PCMCIA_DEVICE_NULL
 };
 MODULE_DEVICE_TABLE(pcmcia, hostap_cs_ids);


-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

Zemsta jest rozkoszą umysłów miernych, słabych i małostkowych. Ale jednak
rozkoszą być nie przestaje

Re: [PATCH] Add Linksys WCF11 to hostap driver

[Pavel Roskin]

Quoting Marcin Juszkiewicz <openembedded-sbG99h22wavzs492ZWNkEA@public.gmane.org>:

> +       PCMCIA_DEVICE_PROD_ID1233(
> +               "The Linksys Group, Inc.", "Wireless Network CF   
> Card", "ISL37300P",
> +               0xa5f472c2, 0x9c05598d, 0xc9049a39),

Acked-by: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>

-- 
Regards,
Pavel Roskin

Re: [PATCH] Add Linksys WCF11 to hostap driver

[John W. Linville]

On Sun, Dec 30, 2007 at 11:39:31AM -0500, Pavel Roskin wrote:
> Quoting Marcin Juszkiewicz <openembedded@haerwu.biz>:
>
>> +       PCMCIA_DEVICE_PROD_ID1233(
>> +               "The Linksys Group, Inc.", "Wireless Network CF  Card", 
>> "ISL37300P",
>> +               0xa5f472c2, 0x9c05598d, 0xc9049a39),
>
> Acked-by: Pavel Roskin <proski@gnu.org>

The ID1234 version of this patch is already in Linus' tree.  Feel free
to submit a patch that redacts it to the ID123 form.

John
-- 
John W. Linville
linville@tuxdriver.com