From: Andreas Henriksson <andreas@fatal.se>
To: shemminger <shemminger@linux-foundation.org>
Cc: netdev <netdev@vger.kernel.org>, Patrick McHardy <kaber@trash.net>
Subject: Re: iproute2 syntax change in tc police?
Date: Wed, 02 Jan 2008 11:14:47 +0100 [thread overview]
Message-ID: <1199268887.16358.37.camel@localhost.localdomain> (raw)
In-Reply-To: <1199230752.16358.22.camel@localhost.localdomain>
On ons, 2008-01-02 at 00:39 +0100, Andreas Henriksson wrote:
[...]
> Commands like "tc filter add dev ppp0 parent ffff: protocol ip prio 50
> u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1"
> apparently no longer works. The flowid is not accepted anymore.
> Reverting commit 720a2e8d99... which you authored seems to "fix" this.
[...]
After further investigation it seems clear to me that reverting the
commit 720a2e8d990707749b2... is the correct thing to do, since the real
fix for the problem this commit was supposed to fix was instead fixed in
commit c29391c7c68f031e246c...
Whatever you specify after a u32 police you will now get a syntax error,
and according to "tc filter add u32 help" there are several things that
you are supposed to be able to specify after a police.
So, Steven, please revert 720a2e8d990707749b2...
--
Regards,
Andreas Henriksson
prev parent reply other threads:[~2008-01-02 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 23:39 iproute2 syntax change in tc police? Andreas Henriksson
2008-01-02 0:43 ` Denys Fedoryshchenko
2008-01-02 10:14 ` Andreas Henriksson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199268887.16358.37.camel@localhost.localdomain \
--to=andreas@fatal.se \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).