netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] IRDA: irda_create() nuke user triggable printk
@ 2008-01-07  0:34 maximilian attems
  2008-01-07  8:31 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: maximilian attems @ 2008-01-07  0:34 UTC (permalink / raw)
  To: davem; +Cc: netdev, samuel, maximilian attems

easy to trigger as user with sfuzz.

irda_create() is quiet on unknown sock->type,
match this behaviour for SOCK_DGRAM unknown protocol

Signed-off-by: maximilian attems <max@stro.at>
---
 net/irda/af_irda.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
index 48ce59a..d5e4dd7 100644
--- a/net/irda/af_irda.c
+++ b/net/irda/af_irda.c
@@ -1118,8 +1118,6 @@ static int irda_create(struct net *net, struct socket *sock, int protocol)
 			self->max_sdu_size_rx = TTP_SAR_UNBOUND;
 			break;
 		default:
-			IRDA_ERROR("%s: protocol not supported!\n",
-				   __FUNCTION__);
 			return -ESOCKTNOSUPPORT;
 		}
 		break;
-- 
debian.1.5.3.7.1-dirty


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] IRDA: irda_create() nuke user triggable printk
  2008-01-07  0:34 [PATCH] IRDA: irda_create() nuke user triggable printk maximilian attems
@ 2008-01-07  8:31 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-07  8:31 UTC (permalink / raw)
  To: max; +Cc: netdev, samuel

From: maximilian attems <max@stro.at>
Date: Mon,  7 Jan 2008 01:34:32 +0100

> easy to trigger as user with sfuzz.
> 
> irda_create() is quiet on unknown sock->type,
> match this behaviour for SOCK_DGRAM unknown protocol
> 
> Signed-off-by: maximilian attems <max@stro.at>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-07  8:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-07  0:34 [PATCH] IRDA: irda_create() nuke user triggable printk maximilian attems
2008-01-07  8:31 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).