From: Jay Vosburgh <fubar@us.ibm.com>
To: netdev@vger.kernel.org
Cc: Jeff Garzik <jgarzik@pobox.com>,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
Krzysztof Oledzki <olel@ans.pl>, Jay Vosburgh <fubar@us.ibm.com>
Subject: [PATCH 2/3] bonding: fix ASSERT_RTNL that produces spurious warnings
Date: Mon, 7 Jan 2008 17:56:59 -0800 [thread overview]
Message-ID: <1199757423867-git-send-email-fubar@us.ibm.com> (raw)
In-Reply-To: <11997574222492-git-send-email-fubar@us.ibm.com>
Move an ASSERT_RTNL down to where we should hold only RTNL;
the existing check produces spurious warnings because we hold additional
locks at _bh, tripping a debug warning in spin_lock_mutex().
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
---
drivers/net/bonding/bond_alb.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 25b8dbf..9b55a12 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -1601,9 +1601,6 @@ void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave
struct slave *swap_slave;
int i;
- if (new_slave)
- ASSERT_RTNL();
-
if (bond->curr_active_slave == new_slave) {
return;
}
@@ -1649,6 +1646,8 @@ void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave
write_unlock_bh(&bond->curr_slave_lock);
read_unlock(&bond->lock);
+ ASSERT_RTNL();
+
/* curr_active_slave must be set before calling alb_swap_mac_addr */
if (swap_slave) {
/* swap mac address */
--
1.5.3.4.206.g58ba4-dirty
next prev parent reply other threads:[~2008-01-08 1:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 1:56 [PATCH 0/3] bonding: 3 fixes for 2.6.24 Jay Vosburgh
2008-01-08 1:56 ` [PATCH 1/3] bonding: fix locking in sysfs primary/active selection Jay Vosburgh
2008-01-08 1:56 ` Jay Vosburgh [this message]
2008-01-08 1:57 ` [PATCH 3/3] bonding: fix locking during alb failover and slave removal Jay Vosburgh
2008-01-08 18:50 ` [PATCH 0/3] bonding: 3 fixes for 2.6.24 Krzysztof Oledzki
2008-01-08 19:17 ` Andy Gospodarek
2008-01-08 20:28 ` Jay Vosburgh
2008-01-09 6:08 ` Herbert Xu
2008-01-08 19:30 ` Jay Vosburgh
2008-01-09 6:35 ` Krzysztof Oledzki
2008-01-09 7:58 ` Jay Vosburgh
2008-01-09 9:36 ` Krzysztof Oledzki
2008-01-09 15:27 ` Andy Gospodarek
2008-01-09 17:54 ` Jay Vosburgh
2008-01-09 20:17 ` Andy Gospodarek
2008-01-09 22:05 ` Herbert Xu
2008-01-09 23:19 ` Jay Vosburgh
2008-01-10 0:58 ` Herbert Xu
2008-01-10 14:51 ` Andy Gospodarek
2008-01-10 20:36 ` Herbert Xu
2008-01-10 20:50 ` Jay Vosburgh
2008-01-10 21:03 ` Andy Gospodarek
2008-01-10 21:05 ` Herbert Xu
2008-01-11 1:06 ` Jay Vosburgh
2008-01-11 4:55 ` Herbert Xu
2008-01-10 20:45 ` Jay Vosburgh
2008-01-12 10:53 ` Krzysztof Oledzki
2008-01-12 17:56 ` Jay Vosburgh
2008-01-13 0:19 ` Herbert Xu
2008-01-14 22:15 ` Krzysztof Oledzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199757423867-git-send-email-fubar@us.ibm.com \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=olel@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).