From: Matthieu Baerts <matttbe@kernel.org>
To: Minxi Hou <houminxi@gmail.com>
Cc: netdev@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 2/2] selftests/net/openvswitch: check that a failed set keeps the features
Date: Wed, 18 Nov 2026 10:45:32 +0100 [thread overview]
Message-ID: <119b21d2-31de-4416-aeed-d1f04ffcfd82@kernel.org> (raw)
In-Reply-To: <20261118065435.2367014-3-houminxi@gmail.com>
Hi Minxi,
Thank you for the new version.
On 18/11/2026 07:54, Minxi Hou wrote:
> Add a set-dp command to ovs-dpctl for the kernel's datapath SET command,
> and two tests that use it.
>
> The first test clears the features of a fresh datapath, sets the dispatch
> bit with a valid pid list, and clears them again. It then sends a set that
> would set that bit with an empty per-cpu-pids. The request has to fail
> with EINVAL, and the datapath has to keep reporting the features it had,
> which a kernel that records them before the change reads as 0x8 instead of
> 0x0. A second request sends OVS_DP_CMD_NEW for that name from an outdated
> client, which makes the kernel drop the features, and a further set has
> to work.
>
> The second test covers the recirc bit. It sets that bit on a fresh datapath
> and sends a set that would set the dispatch bit with an empty per-cpu-pids.
> The rejected request has to leave the recirc bit in place. A kernel that
> records the features first reads 0x8 there instead of 0x4. A datapath
> holds that bit only when the tc skb extension is compiled in, so the test
> prints the reason and skips when the kernel answers EOPNOTSUPP, and any
> other failure of that request fails the test. CONFIG_NET_TC_SKB_EXT
> depends on CONFIG_NET_CLS_ACT and both sit under CONFIG_NET_SCHED, so the
> selftest config fragment selects all three.
>
> The reference count itself is not visible from user space, so the steps
> that use an outdated client only show that those paths run and that a
> datapath keeps working across them.
>
> set-dp sends the features it is given. When --features is left out it
> sends the features the datapath reports, and it refuses to send the
> request when the datapath reports none. A pid list that is not a list of
> numbers is reported as such, and empty entries are dropped.
>
> A failing run deletes debug.log, and ovs_sbx sends a command's stdout into
> that same file, so the tests report a failure reason on stderr. stderr
> still reaches the test runner from inside ovs_sbx, and unlike a duplicated
> stdout it is not a second handle on the runner's pipe. The daemons the
> suite starts outlive the script, and one that inherits such a handle keeps
> the pipe open after the script exits, which leaves the run hanging until
> the harness times out.
>
> Every step that can fail says why it did. A datapath that cannot be read
> is reported as that rather than as a feature mismatch: ovs-dpctl prints a
> missing datapath and exits 0, and it leaves the features line out when the
> kernel does not report them, so the check reads both cases from the output.
>
> Reported-by: Matthieu Baerts <matttbe@kernel.org>
No need to send a new version for that, but next time, I think it would
be better to include an individual changelog per patch in the notes
(under '---'). There, you can mention that the v5 addresses the error
visible on the CI that I reported, instead of adding my Reported-by tag
here: I didn't report the whole issue that makes you write the patch.
(I didn't review the patch, but I can see you did some modifications)
https://netdev-ctrl.bots.linux.dev/ansiview.html?f=/logs/build/1214612/diff/b4-diff.ansi
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-11-18 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:54 [PATCH net v5 0/2] net: openvswitch: fix a feature leak on a failed change Minxi Hou
2026-11-18 6:54 ` [PATCH net v5 1/2] net: openvswitch: do not record user features when the change fails Minxi Hou
2026-11-18 6:54 ` [PATCH net v5 2/2] selftests/net/openvswitch: check that a failed set keeps the features Minxi Hou
2026-11-18 9:45 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119b21d2-31de-4416-aeed-d1f04ffcfd82@kernel.org \
--to=matttbe@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=houminxi@gmail.com \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox