Netdev List
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Donald Hunter <donald.hunter@gmail.com>,
	Danielle Ratson <danieller@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Greg Thelen <gthelen@google.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	"Matthieu Baerts (Netdev Foundation)" <matttbe@kernel.org>,
	"Maxime Chevallier (Netdev Foundation)"
	<maxime.chevallier@bootlin.com>, Paolo Abeni <pabeni@redhat.com>,
	"Remy D. Farley" <one-d-wide@protonmail.com>,
	Simon Horman <horms@kernel.org>,
	Stanislav Fomichev <sdf.kernel@gmail.com>,
	Heng Guo <heng.guo@windriver.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 3/8] tools: ynl: add C-based YNL linter
Date: Fri, 11 Sep 2026 22:27:52 +0000	[thread overview]
Message-ID: <11c42402-bb2b-4bd4-9b55-25bc560b3d12@fiberby.net> (raw)
In-Reply-To: <20260910193348.2ded41aa@kernel.org>

On 9/11/26 2:33 AM, Jakub Kicinski wrote:
> On Thu, 10 Sep 2026 22:17:23 +0000 Asbjørn Sloth Tønnesen wrote:
>> Validate that structures described in YNL match their C counterpart,
>> currently focused on enums.
> 
> I don't see the point of this. LLMs will catch most of the problems
> and for the hundredth time classic netlink is not the focus for YNL.
> Anything genetlink can have YNL generate the code and uAPI so problems
> do no exist.

FTR, I didn't intent to imply any "regular" C code gen on classic families,
the --linter was a very limited output mode, only for validating enum alignment.

I like to also have deterministic checks, the LLM didn't catch the
IPV4_DEVCONF_* alignment issue, while reviewing commit 5e63ade19044
("netlink: specs: rt-link: update ipv6 devconf doc"), where I claimed
that IPV4_DEVCONF_FORWARDING = 1 (while it was 0 in YNL) in patch 1/3.

Now reading the raw log, the closest it got was "... which means there could
be an existing bug in `ipv4-devconf`!", but then it forgot about it, and
that was for patch 3/3. I can't find it in the Clashiko log for that series.

https://sashiko.dev/#/log/148492

> Feel free to keep the code OOT and let's see if you can prove my
> assertion wrong within a couple of release :)

I will keep it OOT for now. Thank you for your review!

> If you have any ready fixes to the spec please post them.
> I'm also sitting on a bunch of fixes based on LLM scans, I'm just
> blocked on the "15 outstanding patches" limit :(

I have posted my fixes for most severe issues now, and left out adding
extra enum-prefix and header entries. I skimmed your new devlink spec
patches, to look for duplicates, but will do a review tomorrow.

  reply	other threads:[~2026-09-11 22:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 22:17 [RFC PATCH net-next 0/8] tools: ynl: C-based YNL linter Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 1/8] netlink: specs: nftables: add uapi-header Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 2/8] netlink: specs: conntrack: " Asbjørn Sloth Tønnesen
2026-09-11  2:35   ` Jakub Kicinski
2026-09-10 22:17 ` [RFC PATCH net-next 3/8] tools: ynl: add C-based YNL linter Asbjørn Sloth Tønnesen
2026-09-11  2:33   ` Jakub Kicinski
2026-09-11 22:27     ` Asbjørn Sloth Tønnesen [this message]
2026-09-10 22:17 ` [RFC PATCH net-next 4/8] netlink: specs: rt-link: add C naming info Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 5/8] netlink: specs: rt-link: re-align IPv4 devconf Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 6/8] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 7/8] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-10 22:17 ` [RFC PATCH net-next 8/8] netlink: specs: rt-link: fix netkit-policy names Asbjørn Sloth Tønnesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11c42402-bb2b-4bd4-9b55-25bc560b3d12@fiberby.net \
    --to=ast@fiberby.net \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=gthelen@google.com \
    --cc=heng.guo@windriver.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=one-d-wide@protonmail.com \
    --cc=pabeni@redhat.com \
    --cc=sdf.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox