From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable Date: Thu, 28 Jun 2018 06:53:23 -0500 Message-ID: <11cc30c2-271e-277c-ced2-c1faa334b11d@ti.com> References: <20180627181618.23463-1-dmurphy@ti.com> <20180627181618.23463-2-dmurphy@ti.com> <20180628082006.GC16727@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , To: Andrew Lunn Return-path: Received: from fllv0016.ext.ti.com ([198.47.19.142]:44728 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933164AbeF1MEQ (ORCPT ); Thu, 28 Jun 2018 08:04:16 -0400 In-Reply-To: <20180628082006.GC16727@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Andrew On 06/28/2018 03:20 AM, Andrew Lunn wrote: > On Wed, Jun 27, 2018 at 01:16:18PM -0500, Dan Murphy wrote: >> If SGMII was selected in the DT then the device should >> write the SGMII enable bit. >> >> If SGMII is not selected in the DT then the SGMII bit >> should be disabled. >> >> Signed-off-by: Dan Murphy >> --- >> arch/arm/configs/omap2plus_defconfig | 1 + >> drivers/net/phy/dp83tc811.c | 20 +++++++++----------- >> 2 files changed, 10 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig >> index 06fb948ecfb3..30857d5b7a6c 100644 >> --- a/arch/arm/configs/omap2plus_defconfig >> +++ b/arch/arm/configs/omap2plus_defconfig >> @@ -182,6 +182,7 @@ CONFIG_TI_CPTS=y >> CONFIG_AT803X_PHY=y >> CONFIG_DP83848_PHY=y >> CONFIG_DP83867_PHY=y >> +CONFIG_DP83TC811_PHY=y >> CONFIG_MICREL_PHY=y >> CONFIG_SMSC_PHY=y >> CONFIG_PPP=m > > Hi Dan > > This change does not belong here. > Correct I will remove it. > Andrew > -- ------------------ Dan Murphy