From: Edward Cree <edward.cree@xilinx.com>
To: Xin Long <lucien.xin@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
"Edward Cree" <ecree@solarflare.com>
Subject: Re: [PATCH net] Documentation: add description for net.core.gro_normal_batch
Date: Tue, 10 May 2022 18:42:22 +0100 [thread overview]
Message-ID: <11f25fef-e551-f72c-223d-c3d072a3a94d@xilinx.com> (raw)
In-Reply-To: <CADvbK_dKQSnmn3z41=88Zoa4xGf55G59Y_ocAtoaJh=Y4JGw+A@mail.gmail.com>
On 10/05/2022 18:10, Xin Long wrote:
> On Mon, May 9, 2022 at 9:07 PM Jakub Kicinski <kuba@kernel.org> wrote:
>> That makes it sounds like only packets which were not coalesced
>> go on the list. IIUC everything goes on that list before traveling
>> up the stack, no?
> I think the difference is these ones held/merged go to gro_list first
> and get merged there, then go to the list. I can change it to:
>
> "place it on a list where the coalesced packets also eventually go"
>
> looks good?
Maybe it'd be clearer to say something like
"when a packet exits GRO, either as a coalesced superframe or as an
original packet which GRO has decided not to coalesce, it is placed on
a per-NAPI list. This list is then passed to the stack when..." etc.
Ideally also mention the fact that a coalesced superframe counts as
napi_gro_cb.count towards the gro_normal_batch limit, not just 1.
-ed
next prev parent reply other threads:[~2022-05-10 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 18:20 [PATCH net] Documentation: add description for net.core.gro_normal_batch Xin Long
2022-05-10 1:07 ` Jakub Kicinski
2022-05-10 17:10 ` Xin Long
2022-05-10 17:42 ` Edward Cree [this message]
2022-05-11 16:20 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f25fef-e551-f72c-223d-c3d072a3a94d@xilinx.com \
--to=edward.cree@xilinx.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).