From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Peter Waskiewicz Jr <peter.waskiewicz.jr@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()
Date: Mon, 28 Aug 2017 09:09:18 +0200 [thread overview]
Message-ID: <11fc2d4e-bcf4-9a1c-6d73-2e67aab2a1ed@users.sourceforge.net> (raw)
In-Reply-To: <E0D909EE5BB15A4699798539EA149D7F0779689E@ORSMSX103.amr.corp.intel.com>
> Did coccinelle trip on the message
I suggest to reconsider this implementation detail with the combination
of a function call like “kzalloc”.
A script for the semantic patch language can point various update candidates
out according to a source code search pattern which is similar to “OOM_MESSAGE”
in the script “checkpatch.pl”.
> or the fact you weren't returning NULL?
How does this concern fit to my update suggestion?
Regards,
Markus
next prev parent reply other threads:[~2017-08-28 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 19:25 [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry() SF Markus Elfring
2017-08-27 23:16 ` Waskiewicz Jr, Peter
2017-08-28 6:05 ` Dan Carpenter
2017-08-28 14:05 ` Waskiewicz Jr, Peter
2017-08-28 7:09 ` SF Markus Elfring [this message]
2017-09-05 13:10 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11fc2d4e-bcf4-9a1c-6d73-2e67aab2a1ed@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.waskiewicz.jr@intel.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).