* [PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue
@ 2008-01-16 11:13 Joonwoo Park
2008-01-18 11:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joonwoo Park @ 2008-01-16 11:13 UTC (permalink / raw)
To: David Miller
Cc: Joonwoo Park, linux-netdev, Stephen Hemminger, Alexander Zubkov
http://bugzilla.kernel.org/show_bug.cgi?id=9493
The fib allows making identical routes with 'ip route replace'.
This patch makes the fib return -EEXIST if replacement would cause duplication.
Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
---
net/ipv4/fib_hash.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..99071d7 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -444,6 +444,9 @@ static int fn_hash_insert(struct fib_table *tb, struct fib_config *cfg)
struct fib_info *fi_drop;
u8 state;
+ if (fi->fib_treeref > 1)
+ goto out;
+
write_lock_bh(&fib_hash_lock);
fi_drop = fa->fa_info;
fa->fa_info = fi;
--
1.5.3.rc5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-18 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-16 11:13 [PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue Joonwoo Park
2008-01-18 11:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).