* Re: [PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work().
2008-01-22 1:08 [PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work() Michael Chan
@ 2008-01-22 1:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-22 1:06 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 21 Jan 2008 17:08:01 -0800
> [BNX2]: Fix minor bug in bnx2_has_work().
>
> It is more correct to get the status block from the bnx2_napi struct
> instead of the bnx2 struct. It happens that they are the same in this
> case because we are using the first MSIX vector.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work().
@ 2008-01-22 1:08 Michael Chan
2008-01-22 1:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2008-01-22 1:08 UTC (permalink / raw)
To: davem, netdev
[BNX2]: Fix minor bug in bnx2_has_work().
It is more correct to get the status block from the bnx2_napi struct
instead of the bnx2 struct. It happens that they are the same in this
case because we are using the first MSIX vector.
Signed-off-by: Michael Chan <mchan@broadcom.com>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 8348af2..7ee7746 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2903,8 +2903,7 @@ bnx2_tx_msix(int irq, void *dev_instance)
static inline int
bnx2_has_work(struct bnx2_napi *bnapi)
{
- struct bnx2 *bp = bnapi->bp;
- struct status_block *sblk = bp->status_blk;
+ struct status_block *sblk = bnapi->status_blk;
if ((bnx2_get_hw_rx_cons(bnapi) != bnapi->rx_cons) ||
(bnx2_get_hw_tx_cons(bnapi) != bnapi->hw_tx_cons))
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-22 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-22 1:08 [PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work() Michael Chan
2008-01-22 1:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).