netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Rick Jones <rick.jones2@hp.com>, Eric Dumazet <dada1@cosmosbay.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: Netperf TCP_RR(loopback) 10% regression	in	2.6.24-rc6,	comparing with 2.6.22
Date: Wed, 23 Jan 2008 11:25:44 +0800	[thread overview]
Message-ID: <1201058744.3151.373.camel@ymzhang> (raw)
In-Reply-To: <1201048944.3151.263.camel@ymzhang>

On Wed, 2008-01-23 at 08:42 +0800, Zhang, Yanmin wrote:
> On Tue, 2008-01-22 at 10:36 -0800, Rick Jones wrote:
> > When parsing the -P option in scan_socket_args() of src/nettest_bsd.c, 
> > netperf is using "break_args()" from src/netsh.c which indeed if the 
> > command line says "-P 12345" will set both the local and remote port 
> > numbers to 12345.  If instead you were to say "-P 12345,"  it will use 
> > 12345 only for the netperf side.  If you say "-P ,12345" it will use 
> > 12345 only for the netserver side.  To set both sides at once to 
> > different values it would be "-P 12345,54321"
> > 
> > In theory, send_udp_rr() in src/nettest_bsd.c (or I suppose 
> > scan_socket_args() could have more code added to it to check for a UDP 
> > test over loopback, but probably needs to be a check for any local IP, 
> > and unless this becomes something bigger than "Doctor! Doctor! It hurts 
> > when I do this!" :) I'm inclined to leave it as caveat benchmarker and 
> > perhaps some additional text in the manual.
> I will instrument kernel to see if kernel does work like it is expected.
> 
> When an issue is found, we shouldn't escape by saying it's nothing to do
> with me.
> 
I went through netperf source again and did a step debug with gdb.

Both sides bind 0.0.0.0:12384 to its own sockets. netperf binds firstly.
When netperf calls connect to configure server 127.0.0.1:12384, kernel chooses
socket A's queue. kernel is correct.

Anther question is no matter who binds 0.0.0.0:12384 firstly, netperf
always sends packets to its own socket. I suspect API connect called by netperf to
configure server ip/port has the side-effect, as server doesn't call connect.

It's good to add additional text in netperf manual.

Sorry and thanks for your guys kind response.

-yanmin



  reply	other threads:[~2008-01-23  3:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1199871330.3298.132.camel@ymzhang>
2008-01-11  9:30 ` Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22 Zhang, Yanmin
2008-01-11 17:56   ` Rick Jones
2008-01-14  3:11     ` Zhang, Yanmin
2008-01-14 17:46       ` Rick Jones
2008-01-22  5:24         ` Zhang, Yanmin
2008-01-22  6:07           ` Zhang, Yanmin
2008-01-22  6:22             ` David Miller
2008-01-22  6:51               ` Zhang, Yanmin
2008-01-22  7:13                 ` Eric Dumazet
2008-01-22  6:27             ` Eric Dumazet
2008-01-22  6:52               ` Zhang, Yanmin
2008-01-22  7:32                 ` David Miller
2008-01-22 18:36             ` Rick Jones
2008-01-23  0:42               ` Zhang, Yanmin
2008-01-23  3:25                 ` Zhang, Yanmin [this message]
2008-01-14  8:44   ` Ilpo Järvinen
2008-01-14  9:21     ` Ilpo Järvinen
2008-01-14  9:38       ` Zhang, Yanmin
2008-01-14 10:53     ` Herbert Xu
2008-01-16  0:34       ` Zhang, Yanmin
2008-01-16  7:15         ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201058744.3151.373.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).