From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: [PATCH] SMC91x: poll_controller(): check for interrupts before calling handler Date: Thu, 24 Jan 2008 21:38:23 -0800 Message-ID: <1201239503-16407-1-git-send-email-khilman@mvista.com> Cc: Nicolas Pitre , Kevin Hilman To: netdev@vger.kernel.org Return-path: Received: from deeprooted.net ([216.254.16.51]:53156 "EHLO paris.hilman.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752400AbYAYFiY (ORCPT ); Fri, 25 Jan 2008 00:38:24 -0500 Sender: netdev-owner@vger.kernel.org List-ID: When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the "spurious interrupt" printk whenever the driver is being polled. Instead, check for actual interrupts before calling smc_interrupt() Signed-off-by: Kevin Hilman Signed-off-by: Nicolas Pitre --- drivers/net/smc91x.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index 7da7589..64ef6c1 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -1350,8 +1350,12 @@ static irqreturn_t smc_interrupt(int irq, void *dev_id) */ static void smc_poll_controller(struct net_device *dev) { + struct smc_local *lp = netdev_priv(dev); + void __iomem *ioaddr = lp->base; + disable_irq(dev->irq); - smc_interrupt(dev->irq, dev); + if (SMC_GET_INT() & SMC_GET_INT_MASK()) + smc_interrupt(dev->irq, dev); enable_irq(dev->irq); } #endif -- 1.5.3.7