Netdev List
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: acme@redhat.com
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: [DCCP] [Patch 0/6] [BUG-Fix]: Fixes for CCID3, seqnos, and dccp_probe
Date: Mon, 28 Jan 2008 10:16:10 +0000	[thread overview]
Message-ID: <1201515376-8280-1-git-send-email-gerrit@erg.abdn.ac.uk> (raw)
In-Reply-To: dccp_ccid3_dccp_probe__bug_fixes

This is a set of bug fixes for CCID3 and general DCCP. 

Please consider patches #1, #2, #3. The remainder are for the test tree
(but are fixes nonetheless) and may not apply directly onto mainline; with
regard to patch #6, please see note at end of message.

Patch #1: Fixes a CCID3 bug: when loss was encountered, the value returned at 
          minimum resolution was wrong and over 80 times too high.

Patch #2: Fixes a bug in the assignment of GAR (used ISR instead of ISS).

Patch #3: Another bug fix: AWL was only ever set after the Response.

Patch #4: Fixes adjustments to AWL and SWL. These were only updated at the
          begin of the connection (where the statements reduced to much 
          simpler assignments), but need to be adjusted for the reception
	  of subsequent packets also.
	  (Note: This patch is best used after going through the feature
	         negotiation patches, since the feature handlers for Sequence
		 Window ensure that these values are up to date.)

Patch #5: As a consequence of the preceding patches, the dccp_connect_init
          function may be merged into dccp_connect. Is a suggestion (which
          would make sense), not a bug fix.

Patch #6: A fix for dccp_probe - this used to be noisy and created huge
          files. By attaching the dccp_probe onto a different function, this
	  was fixed, the output file size shrank by a factor of over 100,
	  with qualitatively the same or better output.


I have put these after the feature-negotiation patches onto

	git://eden-feed.erg.abdn.ac.uk/dccp_exp 	{dccp,ccid4}

and updated the CCID4 tree to take advantage of the dccp_probe update.

If people would like to use the dccp_probe update for a mainline kernel,
I have uploaded a similar patch to patch #6 onto
http://www.erg.abdn.ac.uk/users/gerrit/dccp/dccp_probe_for_mainline.diff

             reply	other threads:[~2008-01-28 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 10:16 Gerrit Renker [this message]
2008-01-28 10:16 ` [PATCH 1/6] [CCID3]: Function returned wrong value Gerrit Renker
2008-01-28 10:16   ` [PATCH 2/6] [DCCP]: Bug in initial acknowledgment number assignment Gerrit Renker
2008-01-28 10:16     ` [PATCH 3/6] [DCCP]: Bug-Fix - AWL was never updated Gerrit Renker
2008-01-28 10:16       ` [PATCH 4/6] [DCCP]: Fix the adjustments to AWL and SWL Gerrit Renker
2008-01-28 10:16         ` [PATCH 5/6] [DCCP]: Merge now-reduced connect_init() function Gerrit Renker
2008-01-28 10:16           ` [PATCH 6/6] [DCCP-PROBE]: Reduce noise in output and convert to ktime_t Gerrit Renker
2008-01-28 17:59       ` [PATCH 3/6] [DCCP]: Bug-Fix - AWL was never updated Ian McDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201515376-8280-1-git-send-email-gerrit@erg.abdn.ac.uk \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=acme@redhat.com \
    --cc=dccp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox