Netdev List
 help / color / mirror / Atom feed
From: Bryan Wu <bryan.wu@analog.com>
To: Kalle Pokki <kalle.pokki@eke.com>
Cc: netdev@vger.kernel.org, Bryan Wu <bryan.wu@analog.com>
Subject: Re: [PATCH] bfin_mac: Make the MDIO polling faster
Date: Wed, 30 Jan 2008 01:47:55 +0800	[thread overview]
Message-ID: <1201628875.26902.14.camel@roc-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0801291427300.7503@pc-213-140-179-32.aina.net>


On Tue, 2008-01-29 at 20:28 +0800, Kalle Pokki wrote:
> The poll routine always got 10 ms penalty when called immediately 
> after starting the transfer. The MDIO transfer takes 25.6 us at the 
> noinal 2.5 MHz, so MAX_TIMEOUT_CNT being 500 is still big enough. 

Exactly, but we got a same fixing already.
It will be sent out soon.

Thanks a lot
-Bryan

> --- 
>  drivers/net/bfin_mac.c |    2 +- 
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c 
> index c199633..d2e6813 100644 
> --- a/drivers/net/bfin_mac.c 
> +++ b/drivers/net/bfin_mac.c 
> @@ -296,7 +296,7 @@ static void mdio_poll(void) 
>   
>         /* poll the STABUSY bit */ 
>         while ((bfin_read_EMAC_STAADD()) & STABUSY) { 
> -               mdelay(10); 
> +               udelay(1); 
>                 if (timeout_cnt-- < 0) { 
>                         printk(KERN_ERR DRV_NAME 
>                         ": wait MDC/MDIO transaction to complete
> timeout\n"); 
> -- 
> 1.4.4.2
> 

      reply	other threads:[~2008-01-29 17:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 12:28 [PATCH] bfin_mac: Make the MDIO polling faster Kalle Pokki
2008-01-29 17:47 ` Bryan Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201628875.26902.14.camel@roc-laptop \
    --to=bryan.wu@analog.com \
    --cc=kalle.pokki@eke.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox