From: jamal <hadi@cyberus.ca>
To: Erik Mouw <mouw@nl.linux.org>
Cc: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
netdev@vger.kernel.org
Subject: Re: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24
Date: Tue, 29 Jan 2008 18:08:28 -0500 [thread overview]
Message-ID: <1201648108.4425.15.camel@localhost> (raw)
In-Reply-To: <20080129214555.GC29300@gateway.home>
On Tue, 2008-29-01 at 22:45 +0100, Erik Mouw wrote:
> > The driver seems buggy. Make it return NETDEV_TX_BUSY instead of -EIO
> > in xircom_start_xmit() and the messages will go away.
>
> Like this?
>
Indeed.
Peter, I suspect that driver is just buggy in some other way as opposed
to being re-entered; couldnt tell by inspection. It is possible it may
be too eager to open up before it really has space.
It will be easy to check your theory by having the driver just check if
it is netif_stopped just before it returns NETDEV_TX_BUSY.
cheers,
jamal
next prev parent reply other threads:[~2008-01-29 23:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 18:47 Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24 Erik Mouw
2008-01-29 19:57 ` Waskiewicz Jr, Peter P
2008-01-29 20:57 ` jamal
2008-01-29 21:45 ` Erik Mouw
2008-01-29 23:08 ` jamal [this message]
2008-01-29 23:12 ` Waskiewicz Jr, Peter P
2008-02-01 14:54 ` Erik Mouw
2008-02-01 19:07 ` Waskiewicz Jr, Peter P
2008-01-29 21:48 ` Waskiewicz Jr, Peter P
2008-01-29 21:00 ` Erik Mouw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201648108.4425.15.camel@localhost \
--to=hadi@cyberus.ca \
--cc=mouw@nl.linux.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).