From: Sam Ravnborg <sam@ravnborg.org>
To: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>, Jeff Garzik <jeff@garzik.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, Jeff Garzik <jgarzik@pobox.com>,
David Miller <davem@davemloft.net>
Subject: [PATCH] isdn: fix section mismatch warning for ISACVer
Date: Fri, 8 Feb 2008 21:00:02 +0100 [thread overview]
Message-ID: <1202500804-32020-2-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <1202500804-32020-1-git-send-email-sam@ravnborg.org>
Fix following warnings:
WARNING: drivers/isdn/hisax/built-in.o(.text+0x19723): Section mismatch in reference from the function ISACVersion() to the variable .devinit.data:ISACVer
WARNING: drivers/isdn/hisax/built-in.o(.text+0x2005b): Section mismatch in reference from the function setup_avm_a1_pcmcia() to the function .devinit.text:setup_isac()
ISACVer were only used from function annotated __devinit
so add same annotation to ISACVer.
One af the fererencing functions missed __devinit so add it
and kill an additional warning.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Karsten Keil <kkeil@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: David Miller <davem@davemloft.net>
---
drivers/isdn/hisax/avm_a1p.c | 3 +--
drivers/isdn/hisax/isac.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/isdn/hisax/avm_a1p.c b/drivers/isdn/hisax/avm_a1p.c
index c87fa3f..3039c6d 100644
--- a/drivers/isdn/hisax/avm_a1p.c
+++ b/drivers/isdn/hisax/avm_a1p.c
@@ -213,8 +213,7 @@ AVM_card_msg(struct IsdnCardState *cs, int mt, void *arg)
return 0;
}
-int
-setup_avm_a1_pcmcia(struct IsdnCard *card)
+int __devinit setup_avm_a1_pcmcia(struct IsdnCard *card)
{
u_char model, vers;
struct IsdnCardState *cs = card->cs;
diff --git a/drivers/isdn/hisax/isac.c b/drivers/isdn/hisax/isac.c
index 4e9f238..6ae9dde 100644
--- a/drivers/isdn/hisax/isac.c
+++ b/drivers/isdn/hisax/isac.c
@@ -27,8 +27,7 @@ static char *ISACVer[] __devinitdata =
{"2086/2186 V1.1", "2085 B1", "2085 B2",
"2085 V2.3"};
-void
-ISACVersion(struct IsdnCardState *cs, char *s)
+void __devinit ISACVersion(struct IsdnCardState *cs, char *s)
{
int val;
--
1.5.4.rc3.14.g44397
next prev parent reply other threads:[~2008-02-08 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 20:00 [PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card Sam Ravnborg
2008-02-08 20:00 ` Sam Ravnborg [this message]
2008-02-10 7:29 ` [PATCH] isdn: fix section mismatch warning for ISACVer David Miller
2008-02-08 20:00 ` [PATCH] isdn: fix section mismatch warnings in isac.c and isar.c Sam Ravnborg
2008-02-10 7:28 ` David Miller
2008-02-08 20:00 ` [PATCH] isdn: fix section mismatch warning in hfc_sx.c Sam Ravnborg
2008-02-10 7:27 ` David Miller
2008-02-10 7:29 ` [PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202500804-32020-2-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).