From: Dan Williams <dcbw@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Roland Dreier <rdreier@cisco.com>,
Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] libertas: Don't mark exported symbols as static
Date: Sat, 09 Feb 2008 08:52:35 -0500 [thread overview]
Message-ID: <1202565155.15334.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20080209044858.GA1428@infradead.org>
On Fri, 2008-02-08 at 23:48 -0500, Christoph Hellwig wrote:
> On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote:
> > > Why not pull the exports? they aren't used anywhere in the existing kernel.
> >
> > I'm guessing there's some not-(yet-)merged mesh networking stuff that
> > uses the symbols, but it doesn't matter much to me...
>
> The general rule is to not keep symbols for out of tree stuff, so
> removing the exports makes more sense.
If they aren't used in the in-kernel driver, just kill the export
statements.
Dan
next prev parent reply other threads:[~2008-02-09 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 0:07 [PATCH] libertas: Don't mark exported symbols as static Roland Dreier
2008-02-09 0:28 ` Stephen Hemminger
2008-02-09 2:01 ` Roland Dreier
2008-02-09 4:48 ` Christoph Hellwig
2008-02-09 13:52 ` Dan Williams [this message]
2008-02-12 23:08 ` [PATCH] libertas: Remove unused exports Roland Dreier
2008-02-24 4:10 ` [PATCH RESEND] " Roland Dreier
[not found] ` <aday79b571e.fsf_-_-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2008-02-25 19:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202565155.15334.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).