From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
gemini-board-dev@lists.berlios.de, netdev@vger.kernel.org,
"Christoph Biedl" <linux-kernel.bfrz@manchmal.in-ulm.de>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>
Subject: Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver
Date: Mon, 27 Dec 2010 21:12:22 -0800 (PST) [thread overview]
Message-ID: <1202721929.17594.1293513142947.JavaMail.root@tahiti.vyatta.com> (raw)
In-Reply-To: <1293511020.2928.105.camel@localhost>
----- Original Message -----
> On Mon, 2010-12-27 at 20:21 +0100, Hans Ulli Kroll wrote:
> [...]
> > BTW:
> >
> > Why u64_stats ?
> > I see only a few driver are using u64_stats.
> > vlan, br_device and some intel driver
> > no gigabit driver for marvell devices uses u64_stats
>
> All new net drivers should implement 64-bit stats. net_device_stats is
> kept for backward compatibility because we couldn't change all the
> existing drivers at once (it's not a simple change for all of them).
>
> Ben.
BS. drivers with old stats are fine. 64 bit only really matters
at higher speed. Anyway, it is the kind of thing that can easily
be fixed later after driver is merged.
next prev parent reply other threads:[~2010-12-28 5:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 10:32 [RFC PATCH v2] Gemini: Gigabit ethernet driver Michał Mirosław
2010-12-27 19:21 ` Hans Ulli Kroll
2010-12-28 4:37 ` Ben Hutchings
2010-12-28 5:12 ` Stephen Hemminger [this message]
2010-12-29 16:56 ` Hans Ulli Kroll
2010-12-29 18:30 ` Eric Dumazet
2010-12-29 19:28 ` Stephen Hemminger
2010-12-29 19:52 ` Eric Dumazet
2010-12-29 19:57 ` Stephen Hemminger
2010-12-29 21:42 ` Ben Hutchings
2010-12-28 11:45 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202721929.17594.1293513142947.JavaMail.root@tahiti.vyatta.com \
--to=stephen.hemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=gemini-board-dev@lists.berlios.de \
--cc=linux-kernel.bfrz@manchmal.in-ulm.de \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).