netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: Alan Cox <alan@redhat.com>
Cc: Patrick McHardy <kaber@trash.net>
Cc: <netdev@vger.kernel.org>
Cc: <jgarzik@pobox.com>
Subject: [PATCH 1/1] Net: kconfig, correct traffic shaper
Date: Sat,  4 Nov 2006 21:52:12 +0100 (CET)	[thread overview]
Message-ID: <1202725131414221392@wsc.cz> (raw)
In-Reply-To: <453BA26D.9010504@trash.net>

Patrick McHardy <kaber@trash.net> wrote:
> While you're at it .. CBQ is actually not a very good alternative
> since it doesn't work properly on top of virtual network devices.
> The closest match for an alternative would be TBF, but HTB and
> HFSC also do fine. Maybe just point to the traffic schedulers in
> general. I think you could also change EXPERIMENTAL to OBSOLETE
> for the shaper device, the traffic schedulers are a lot more
> flexible.

Ok, thanks for comments. Here it comes, please (n)ack it:

--

kconfig, correct traffic shaper

As Patrick McHardy <kaber@trash.net> suggested, Traffic Shaper is
now obsolete and alternative to it is no longer CBQ, since its problems with
virtual devices, alter Kconfig text to reflect this -- put a link to the
traffic schedulers as a whole.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@redhat.com>
Cc: Patrick McHardy <kaber@trash.net>

---
commit 95045e128e4db8cc07b9a616e6c1f3606b3b499f
tree 3e924080ba76042c93e687a156483d6279e961ed
parent 7e8fb7980d776e6a7c0bd84cc48b1cb9de139b8f
author Jiri Slaby <jirislaby@gmail.com> Sat, 04 Nov 2006 21:41:33 +0059
committer Jiri Slaby <jirislaby@gmail.com> Sat, 04 Nov 2006 21:41:33 +0059

 drivers/net/Kconfig |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index ee5ce6b..2ede616 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2847,7 +2847,7 @@ config NET_FC
 	  "SCSI generic support".
 
 config SHAPER
-	tristate "Traffic Shaper (EXPERIMENTAL)"
+	tristate "Traffic Shaper (OBSOLETE)"
 	depends on EXPERIMENTAL
 	---help---
 	  The traffic shaper is a virtual network device that allows you to
@@ -2856,9 +2856,9 @@ config SHAPER
 	  these virtual devices. See
 	  <file:Documentation/networking/shaper.txt> for more information.
 
-	  An alternative to this traffic shaper is the experimental
-	  Class-Based Queuing (CBQ) scheduling support which you get if you
-	  say Y to "QoS and/or fair queuing" above.
+	  An alternative to this traffic shaper are traffic schedulers which
+	  you'll get if you say Y to "QoS and/or fair queuing" in
+	  "Networking options".
 
 	  To compile this driver as a module, choose M here: the module
 	  will be called shaper.  If unsure, say N.

  reply	other threads:[~2006-11-04 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 15:40 [PATCH 1/1] net: correct-Traffic-shaper-Kconfig Jiri Slaby
2006-10-22 16:55 ` Patrick McHardy
2006-11-04 20:52   ` Jiri Slaby [this message]
2006-11-05 14:34     ` [PATCH 1/1] Net: kconfig, correct traffic shaper Patrick McHardy
2006-11-06  7:52     ` Jeff Garzik
2006-11-06 22:36       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202725131414221392@wsc.cz \
    --to=jirislaby@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).