[PATCH] [IRDA] irda_init() nuke useless debug printk

[PATCH] [IRDA] irda_init() nuke useless debug printk

[maximilian attems]

irda_init()
dmesg line is not really informative, thus remove it.
There are better ways to know that a module is loaded.

Seen on a debian config with IRDA_DEBUG enabled.

Signed-off-by: maximilian attems <max@stro.at>
---
 net/irda/irmod.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/irda/irmod.c b/net/irda/irmod.c
index 01554b9..73db875 100644
--- a/net/irda/irmod.c
+++ b/net/irda/irmod.c
@@ -90,8 +90,6 @@ static int __init irda_init(void)
 {
 	int ret = 0;
 
-	IRDA_DEBUG(0, "%s()\n", __FUNCTION__);
-
 	/* Lower layer of the stack */
 	irlmp_init();
 	irlap_init();
-- 
1.5.4

Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

[David Miller]

From: maximilian attems <max@stro.at>
Date: Tue, 12 Feb 2008 11:30:47 +0100

> irda_init()
> dmesg line is not really informative, thus remove it.
> There are better ways to know that a module is loaded.
> 
> Seen on a debian config with IRDA_DEBUG enabled.
> 
> Signed-off-by: maximilian attems <max@stro.at>

Well if you look at how IRDA_DEBUG is predominantly used,
it's a function tracer, and that's exactly how it's being
used here.

Either we decide that this is OK and leave it there, or
we start moving the whole IRDA tree over to not do this.
Not something in between.

Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

[maximilian attems]

On Tue, 12 Feb 2008, David Miller wrote:

> From: maximilian attems <max@stro.at>
> Date: Tue, 12 Feb 2008 11:30:47 +0100
> 
> > irda_init()
> > dmesg line is not really informative, thus remove it.
> > There are better ways to know that a module is loaded.
> > 
> > Seen on a debian config with IRDA_DEBUG enabled.
> > 
> > Signed-off-by: maximilian attems <max@stro.at>
> 
> Well if you look at how IRDA_DEBUG is predominantly used,
> it's a function tracer, and that's exactly how it's being
> used here.
> 
> Either we decide that this is OK and leave it there, or
> we start moving the whole IRDA tree over to not do this.
> Not something in between.

ack, happy with both.
i could also lower the visibility of that one.

it simply struck out on my sfuzz test runs, had this
dmesg line instead of usual stuff:
-- snipp
NET: Registered protocol family 9
X.25 for Linux Version 0.2
Bridge firewalling registered
PPP generic driver version 2.4.2
NET: Registered protocol family 24
Sangoma WANPIPE Router v1.1 (c) 1995-2000 Sangoma Technologies Inc.
NET: Registered protocol family 4
NET4: DECnet for Linux: V.2.5.68s (C) 1995-2003 Linux DECnet Project Team
DECnet: Routing cache hash table of 1024 buckets, 16Kbytes
NET: Registered protocol family 12
Bluetooth: Core ver 2.11
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
NET: Registered protocol family 15
NET: Registered protocol family 5
irda_init()
NET: Registered protocol family 23
--