netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* e1000e hardware CRC stripping breaks bridging
@ 2008-02-12 13:27 Daniel Drake
  2008-02-12 13:57 ` Johan Andersson
  2008-02-12 17:25 ` Kok, Auke
  0 siblings, 2 replies; 5+ messages in thread
From: Daniel Drake @ 2008-02-12 13:27 UTC (permalink / raw)
  To: Auke Kok; +Cc: netdev

Hi,

Johan Andersson reported on the Gentoo bugzilla that the hardware CRC 
stripping enabled by e1000e breaks bridging because sometimes the CRC is 
not stripped:
https://bugs.gentoo.org/show_bug.cgi?id=209235

Apparently "upstream" are aware but I couldn't find any mails or bug 
reports on this topic.

What's the current status of this issue? Perhaps we should disable 
hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: e1000e hardware CRC stripping breaks bridging
  2008-02-12 13:27 e1000e hardware CRC stripping breaks bridging Daniel Drake
@ 2008-02-12 13:57 ` Johan Andersson
  2008-02-12 17:23   ` Andy Gospodarek
  2008-02-12 17:25 ` Kok, Auke
  1 sibling, 1 reply; 5+ messages in thread
From: Johan Andersson @ 2008-02-12 13:57 UTC (permalink / raw)
  To: Daniel Drake; +Cc: Auke Kok, netdev

Here is the bug report:
http://bugzilla.kernel.org/show_bug.cgi?id=9940

/Johan

On Tue, 2008-02-12 at 13:27 +0000, Daniel Drake wrote:
> Hi,
> 
> Johan Andersson reported on the Gentoo bugzilla that the hardware CRC 
> stripping enabled by e1000e breaks bridging because sometimes the CRC is 
> not stripped:
> https://bugs.gentoo.org/show_bug.cgi?id=209235
> 
> Apparently "upstream" are aware but I couldn't find any mails or bug 
> reports on this topic.
> 
> What's the current status of this issue? Perhaps we should disable 
> hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?
> 
> Thanks,
> Daniel
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: e1000e hardware CRC stripping breaks bridging
  2008-02-12 13:57 ` Johan Andersson
@ 2008-02-12 17:23   ` Andy Gospodarek
  0 siblings, 0 replies; 5+ messages in thread
From: Andy Gospodarek @ 2008-02-12 17:23 UTC (permalink / raw)
  To: Johan Andersson; +Cc: Daniel Drake, Auke Kok, netdev

On Tue, Feb 12, 2008 at 02:57:50PM +0100, Johan Andersson wrote:
> Here is the bug report:
> http://bugzilla.kernel.org/show_bug.cgi?id=9940
> 
> /Johan
> 
> On Tue, 2008-02-12 at 13:27 +0000, Daniel Drake wrote:
> > Hi,
> > 
> > Johan Andersson reported on the Gentoo bugzilla that the hardware CRC 
> > stripping enabled by e1000e breaks bridging because sometimes the CRC is 
> > not stripped:
> > https://bugs.gentoo.org/show_bug.cgi?id=209235
> > 
> > Apparently "upstream" are aware but I couldn't find any mails or bug 
> > reports on this topic.
> > 
> > What's the current status of this issue? Perhaps we should disable 
> > hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?
> > 
> > Thanks,
> > Daniel


This patch, just needs to get reverted:

commit 140a74802894e9db57e5cd77ccff77e590ece5f3
Author: Auke Kok <auke-jan.h.kok@intel.com>
Date:   Thu Oct 25 13:57:58 2007 -0700

    e1000e: Re-enable SECRC - crc stripping


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: e1000e hardware CRC stripping breaks bridging
  2008-02-12 13:27 e1000e hardware CRC stripping breaks bridging Daniel Drake
  2008-02-12 13:57 ` Johan Andersson
@ 2008-02-12 17:25 ` Kok, Auke
  2008-02-12 20:20   ` Johan Andersson
  1 sibling, 1 reply; 5+ messages in thread
From: Kok, Auke @ 2008-02-12 17:25 UTC (permalink / raw)
  To: Daniel Drake; +Cc: netdev, johan.andersson, dsd, jesse.brandeburg

Daniel Drake wrote:
> Johan Andersson reported on the Gentoo bugzilla that the hardware CRC
> stripping enabled by e1000e breaks bridging because sometimes the CRC is
> not stripped:
> https://bugs.gentoo.org/show_bug.cgi?id=209235
> 
> Apparently "upstream" are aware but I couldn't find any mails or bug
> reports on this topic.
> 
> What's the current status of this issue? Perhaps we should disable
> hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Jesse figured it out. I just send you a patch to test, can you guys give that a
try and see if it fixes the situation? Johan?

thanks,

Auke

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: e1000e hardware CRC stripping breaks bridging
  2008-02-12 17:25 ` Kok, Auke
@ 2008-02-12 20:20   ` Johan Andersson
  0 siblings, 0 replies; 5+ messages in thread
From: Johan Andersson @ 2008-02-12 20:20 UTC (permalink / raw)
  To: Kok, Auke; +Cc: Daniel Drake, netdev, jesse.brandeburg

Kok, Auke wrote:
> Jesse figured it out. I just send you a patch to test, can you guys give that a
> try and see if it fixes the situation? Johan?
>
> thanks,
>
> Auke
>   
Yes, I will test this patch right away.

/Johan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-12 20:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-12 13:27 e1000e hardware CRC stripping breaks bridging Daniel Drake
2008-02-12 13:57 ` Johan Andersson
2008-02-12 17:23   ` Andy Gospodarek
2008-02-12 17:25 ` Kok, Auke
2008-02-12 20:20   ` Johan Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).