netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [XFRM] Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS
@ 2008-02-15 15:08 Johann Felix Soden
  2008-02-15 23:24 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Johann Felix Soden @ 2008-02-15 15:08 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev

From: Johann Felix Soden <johfel@users.sourceforge.net>

With INET=n and XFRM_STATISTICS=y I get the following build failure:

net/built-in.o: In function `xfrm_init':
(.init.text+0xcd7): undefined reference to `snmp_mib_init'

Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
CC: Masahide NAKAMURA <nakam@linux-ipv6.org>
---
 net/xfrm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 8f9dbec..3bf2338 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -38,7 +38,7 @@ config XFRM_MIGRATE
 
 config XFRM_STATISTICS
 	bool "Transformation statistics (EXPERIMENTAL)"
-	depends on XFRM && PROC_FS && EXPERIMENTAL
+	depends on XFRM && PROC_FS && INET && EXPERIMENTAL
 	---help---
 	  This statistics is not a SNMP/MIB specification but shows
 	  statistics about transformation error (or almost error) factor
-- 
1.5.4.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [XFRM] Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS
  2008-02-15 15:08 [PATCH] [XFRM] Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS Johann Felix Soden
@ 2008-02-15 23:24 ` David Miller
  2008-02-16  2:20   ` Masahide NAKAMURA
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-02-15 23:24 UTC (permalink / raw)
  To: johfel; +Cc: netdev

From: Johann Felix Soden <johfel@gmx.de>
Date: Fri, 15 Feb 2008 16:08:43 +0100

> From: Johann Felix Soden <johfel@users.sourceforge.net>
> 
> With INET=n and XFRM_STATISTICS=y I get the following build failure:
> 
> net/built-in.o: In function `xfrm_init':
> (.init.text+0xcd7): undefined reference to `snmp_mib_init'
> 
> Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
> CC: Masahide NAKAMURA <nakam@linux-ipv6.org>

A fix for this has been in my net-2.6 tree for a few days,
and Linus pulled it in this morning.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [XFRM] Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS
  2008-02-15 23:24 ` David Miller
@ 2008-02-16  2:20   ` Masahide NAKAMURA
  0 siblings, 0 replies; 3+ messages in thread
From: Masahide NAKAMURA @ 2008-02-16  2:20 UTC (permalink / raw)
  To: David Miller; +Cc: johfel, netdev

Saturday 16 February 2008 08:24, David Miller wrote:
> From: Johann Felix Soden <johfel@gmx.de>
> Date: Fri, 15 Feb 2008 16:08:43 +0100
> 
> > From: Johann Felix Soden <johfel@users.sourceforge.net>
> > 
> > With INET=n and XFRM_STATISTICS=y I get the following build failure:
> > 
> > net/built-in.o: In function `xfrm_init':
> > (.init.text+0xcd7): undefined reference to `snmp_mib_init'
> > 
> > Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
> > CC: Masahide NAKAMURA <nakam@linux-ipv6.org>
> 
> A fix for this has been in my net-2.6 tree for a few days,
> and Linus pulled it in this morning.

Thank you guys for taking care of it.

-- 
Masahide NAKAMURA

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-16  2:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-15 15:08 [PATCH] [XFRM] Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS Johann Felix Soden
2008-02-15 23:24 ` David Miller
2008-02-16  2:20   ` Masahide NAKAMURA

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).